fix(cli): notices refresh doesn't respect the --no-notices flag#19226
Merged
mergify[bot] merged 2 commits intomasterfrom Mar 7, 2022
Merged
fix(cli): notices refresh doesn't respect the --no-notices flag#19226mergify[bot] merged 2 commits intomasterfrom
mergify[bot] merged 2 commits intomasterfrom
Conversation
|
|
rix0rrr
approved these changes
Mar 7, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TheRealAmazonKendra
pushed a commit
to TheRealAmazonKendra/aws-cdk
that referenced
this pull request
Mar 11, 2022
…19226) The `--no-notices` flag is only being considered for actually displaying the notices, but not in the refresh step, used to mask latency. Also handling request timeout on the `Promise` level. If the promise doesn't resolve within the time limit, resolve with an empty array, no matter what. Fixes aws#19201. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--no-noticesflag is only being considered for actually displaying the notices, but not in the refresh step, used to mask latency.Also handling request timeout on the
Promiselevel. If the promise doesn't resolve within the time limit, resolve with an empty array, no matter what.Fixes #19201.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license