feat(autoscaling): support warm pools#19214
feat(autoscaling): support warm pools#19214mergify[bot] merged 6 commits intoaws:masterfrom jungseoklee:for-aws-autoscaling-warm-pool
Conversation
|
|
|
Here are changes since the first revision:
|
kaizencc
left a comment
There was a problem hiding this comment.
Hi @jungseoklee, this looks like a good start. A few preliminary comments for my first iteration.
Thanks for all comments! |
This patch adds an interface to create a warm pool easily.
|
The PR Linter failure is related to this commit. Could CDK maintainer check if the following regex is correct? Do we need to change regex as below because of file path? |
|
Here are changes since the second revision:
|
There was a problem hiding this comment.
@jungseoklee This is almost good to go. I will update the defaults myself, but leave the conversation about minSize and poolState up for you to see/discuss.
Re: pr-linter, looks like we changed it already so it should be correct when we merge from master.
Thanks for reviewing the PR, @kaizen3031593 ! |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* ### Summary This PR adds an interface to create a warm pool easily, which gives an ability to decrease latency for applications that have exceptionally long boot times: https://docs.aws.amazon.com/autoscaling/ec2/userguide/ec2-auto-scaling-warm-pools.html ### Test - Run unit test and integration test. ``` PASS test/warm-pool.test.js ... =============================== Coverage summary =============================== Statements : 93.22% ( 413/443 ) Branches : 87% ( 288/331 ) Functions : 93.39% ( 99/106 ) Lines : 92.95% ( 396/426 ) ================================================================================ ... Verifying integ.warm-pool.js against integ.warm-pool.expected.json ... OK. ... ``` ### Notes - I borrowed description from [AWS public doc](https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_PutWarmPool.html) for docstring.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Summary
This PR adds an interface to create a warm pool easily, which gives an ability to decrease latency for applications that have exceptionally long boot times: https://docs.aws.amazon.com/autoscaling/ec2/userguide/ec2-auto-scaling-warm-pools.html
Test
Notes