feat(servicecatalog): Service Catalog is now in Developer Preview#19204
feat(servicecatalog): Service Catalog is now in Developer Preview#19204mergify[bot] merged 18 commits intoaws:masterfrom
Conversation
…loper Preview Update some of our readme language based on feedback. Moving library to developer preview with expectation to move to stable soon.
|
|
| - [Tag update constraint](#tag-update-constraint) | ||
| - [Notify on stack events](#notify-on-stack-events) | ||
| - [CloudFormation parameters constraint](#cloudformation-parameters-constraint) | ||
| - [CloudFormation template parameters constraint](#cloudformation-template-parameters-constraint) |
There was a problem hiding this comment.
Thoughts on CloudFormation template constraint instead?
Underlying SC terminology is that it is a Template Constraint and that Parameters are one of the examples a rule can apply to.
There was a problem hiding this comment.
I think we've been moving towards more explicit naming. I'm not actually sure if assertions can apply to anything but the parameters in a meaningful way?
Co-authored-by: Dillon <dponzo18@gmail.com>
|
This is weird, build fails with: I've just copied other PRs that only have the two changes to stability banner and package.json, not sure what is required now. |
|
Run |
Thanks, didn't realize a script was supposed to make those changes. Also linting is failing since no test changes, again I referenced other PRs but this might be a newer condition, should we have a test that asserts stability or something? |
|
Nah, I'll just add a label suppressing that rule. |
skinny85
left a comment
There was a problem hiding this comment.
Looks good, but please be consistent with making sure the line lengths don't get out of hand in the ReadMe file.
| When launching a product, both the TagOptions associated with the product and the containing portfolio are made available. | ||
|
|
||
| At the moment, TagOptions can only be disabled in the console. | ||
| At the moment, TagOptions can only be deactivated in the console. |
There was a problem hiding this comment.
Should we add this capability to the CDK L2? Seems very easy.
There was a problem hiding this comment.
We could revisit this, the issue is that you cannot create a tagOption in a disabled state, only on update can it be deactivated. If we can have way to check for an on update in synth we could handle this.
There was a problem hiding this comment.
We can just underscore that in the documentation I think.
Co-authored-by: Adam Ruka <adamruka85@gmail.com>
Co-authored-by: Adam Ruka <adamruka85@gmail.com>
Co-authored-by: Adam Ruka <adamruka85@gmail.com>
Co-authored-by: Adam Ruka <adamruka85@gmail.com>
Co-authored-by: Adam Ruka <adamruka85@gmail.com>
Co-authored-by: Adam Ruka <adamruka85@gmail.com>
|
:| Small screen IDE auto wraps lines for me, I thought there used to be a linting rule that would fail? but I think they removed some of the stricter rules on the README since rosetta silently fails sometimes. |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@arcrank you might also want to think about doing this for the Service Catalog AppRegistry module (unless, of course, you think it's not mature enough to be called "Developer Preview"). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Yup, already reached out to team, they expect some significant changes coming within < 6 months so holding off there. Thanks for being on top of things. |
…s#19204) Update some `README` documentation based on feedback. Move library to developer preview with no anticipation of breaking changes. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Update some
READMEdocumentation based on feedback.Move library to developer preview with no anticipation of breaking changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license