fix(rds): allow cluster from snapshot to enable encrypted storage#19175
fix(rds): allow cluster from snapshot to enable encrypted storage#19175mergify[bot] merged 4 commits intoaws:masterfrom
Conversation
|
|
| vpc, | ||
| }, | ||
| snapshotIdentifier: 'mySnapshot', | ||
| storageEncryptionKey: new kms.Key(stack, 'Key'), |
There was a problem hiding this comment.
How about using an imported Key in the test (Key.fromKeyArn())? I think that will make the test read nicer.
| 'Key961B73FD', | ||
| 'Arn', | ||
| ], | ||
| }, |
There was a problem hiding this comment.
Can you also assert here StorageEncryption is true?
| vpc, | ||
| }, | ||
| snapshotIdentifier: 'mySnapshot', | ||
| storageEncryptionKey: kms.Key.fromKeyArn(stack, 'Key', 'KeyArn'), |
There was a problem hiding this comment.
Pretty sure you need an actual ARN here 😉. See here.
| 'Fn::GetAtt': [ | ||
| 'Key961B73FD', | ||
| 'Arn', | ||
| ], |
There was a problem hiding this comment.
Pretty sure this assertions is now incorrect 🙂.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…s#19175) Closes aws#17241 Tested by: ```typescript // 1. Create original cluster with unencrypted storage new DatabaseCluster(stack, 'Database', { engine: DatabaseClusterEngine.AURORA, instanceProps: { vpc }, }); // 2. Take snapshot of cluster (mySnapshot) // 3. Create cluster from snapshot with encrypted storage new DatabaseClusterFromSnapshot(stack, 'Database', { engine: DatabaseClusterEngine.AURORA, instanceProps: { vpc }, snapshotIdentifier: 'mySnapshot', storageEncryptionKey: new kms.Key(stack, 'Key'), }); // 4. Verify new cluster has encrypted storage ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes #17241
Tested by:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license