feat(pipelines): add support for caching to codebuild steps#19084
Closed
johnameyer wants to merge 1 commit intoaws:mainfrom
Closed
feat(pipelines): add support for caching to codebuild steps#19084johnameyer wants to merge 1 commit intoaws:mainfrom
johnameyer wants to merge 1 commit intoaws:mainfrom
Conversation
|
|
Contributor
|
@johnameyer Seems that in PR only issue is linting. We wait this PR eagerly get rid of our custom step implementation, as now caching is the only part missing. @rix0rrr Is there some other issues preventing the merge of this PR than tests? |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
@johnameyer / @rix0rrr Is this going to be handled, or is there some issues preventing to put this through? Just wondering if new PR should be opened. |
Author
|
I don't know... @rix0rrr anything I need to take care of here? |
Contributor
|
@rix0rrr @johnameyer Builds seem to be going through, and only issues mentioned are that branch is out of date with base and reviews are required.
|
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jun 15, 2022
Fixes #16375 Closes #19084 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
daschaa
pushed a commit
to daschaa/aws-cdk
that referenced
this pull request
Jul 9, 2022
Fixes aws#16375 Closes aws#19084 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16375
Didn't see unit tests in the package for subnetSelection
Was pondering adding to codeBuildDefaults, but didn't imagine much usage there.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license