docs(elasticloadbalancingv2): clarify the behavior of the open listener property#19019
Merged
mergify[bot] merged 2 commits intoaws:masterfrom Feb 17, 2022
corymhall:corymhall/elbv2-listener-docs
Merged
docs(elasticloadbalancingv2): clarify the behavior of the open listener property#19019mergify[bot] merged 2 commits intoaws:masterfrom corymhall:corymhall/elbv2-listener-docs
open listener property#19019mergify[bot] merged 2 commits intoaws:masterfrom
corymhall:corymhall/elbv2-listener-docs
Conversation
…ener property The documentation for the `open` property leads to some confusion on the actual behavior. Setting `open` to `true` will not open up the listener since listeners do not have security groups. It will instead open up the load balancer on the listener port. There is a bug report #6281 that says this property should be moved to the load balancer, but I think the current behavior is the intended behavior and that the current documentation just makes it confusing. The intention of this property is to give an easy way to add a security group rule to the load balancer security group that allows anyone to access the load balancer on the port of the listener. If we were to move this property to the load balancer it would become more cumbersome because we would have to also provide the port that we want to allow traffic on (load balancers do not have a port). closes #6281
|
|
rix0rrr
approved these changes
Feb 17, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…ener property (aws#19019) The documentation for the `open` property leads to some confusion on the actual behavior. Setting `open` to `true` will not open up the listener since listeners do not have security groups. It will instead open up the load balancer on the listener port. There is a bug report aws#6281 that says this property should be moved to the load balancer, but I think the current behavior is the intended behavior and that the current documentation just makes it confusing. The intention of this property is to give an easy way to add a security group rule to the load balancer security group that allows anyone to access the load balancer on the port of the listener. If we were to move this property to the load balancer it would become more cumbersome because we would have to also provide the port that we want to allow traffic on (load balancers do not have a port). closes aws#6281 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation for the
openproperty leads to some confusion on theactual behavior. Setting
opentotruewill not open up the listenersince listeners do not have security groups. It will instead open up the
load balancer on the listener port.
There is a bug report #6281 that says this property should be moved to
the load balancer, but I think the current behavior is the intended
behavior and that the current documentation just makes it confusing.
The intention of this property is to give an easy way to add a security
group rule to the load balancer security group that allows anyone to
access the load balancer on the port of the listener. If we were to move
this property to the load balancer it would become more cumbersome
because we would have to also provide the port that we want to allow
traffic on (load balancers do not have a port).
closes #6281
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license