chore: compat checks fail if a release has happened#19017
Merged
mergify[bot] merged 2 commits intomasterfrom Feb 21, 2022
Merged
chore: compat checks fail if a release has happened#19017mergify[bot] merged 2 commits intomasterfrom
mergify[bot] merged 2 commits intomasterfrom
Conversation
If a PR is branched off of a version that introduces a new
package, and lives longer than the release, the "does package
exist?" check is wrong, and fails the PR build.
This is usually fixed by another "Update from master", but that's
an annoying step that sometimes takes a while.
- Let's say the branch was forked at 1.142.0
- The branch adds a new package
- That package is released as its initial version as 1.143.0
- When the PR next builds (still at 1.142.0), it will do the following
checks:
- Does the package exist at all? (Answer: yes)
- If so, try to install it at 1.142.0, because that's what we're
diffing against (This explodes, because the package does not exist
at that version).
Instead of doing a versionless "does the package exist at all" check,
always check the existence of the actual version we'll be diffing
against.
|
|
iliapolo
approved these changes
Feb 21, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
If a PR is branched off of a version that introduces a new
package, and lives longer than the release, the "does package
exist?" check is wrong, and fails the PR build.
This is usually fixed by another "Update from master", but that's
an annoying step that sometimes takes a while.
- Let's say the branch was forked at 1.142.0
- The branch adds a new package
- That package is released as its initial version as 1.143.0
- When the PR next builds (still at 1.142.0), it will do the following
checks:
- Does the package exist at all? (Answer: yes)
- If so, try to install it at 1.142.0, because that's what we're
diffing against (This explodes, because the package does not exist
at that version).
Instead of doing a versionless "does the package exist at all" check,
always check the existence of the actual version we'll be diffing
against.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a PR is branched off of a version that introduces a new
package, and lives longer than the release, the "does package
exist?" check is wrong, and fails the PR build.
This is usually fixed by another "Update from master", but that's
an annoying step that sometimes takes a while.
checks:
diffing against (This explodes, because the package does not exist
at that version).
Instead of doing a versionless "does the package exist at all" check,
always check the existence of the actual version we'll be diffing
against.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license