Skip to content

feat(core): stack synthesizer that uses CLI credentials#18963

Merged
mergify[bot] merged 7 commits intomasterfrom
huijbers/synthesizers
Feb 18, 2022
Merged

feat(core): stack synthesizer that uses CLI credentials#18963
mergify[bot] merged 7 commits intomasterfrom
huijbers/synthesizers

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Feb 14, 2022

Clarify documentation of stack synthesizers a bit more, it was very
short. Also add CliCredentialStackSynthesizer. Many corporate users
have requested to be able to NOT use the default bootstrap roles,
because they want to rely on user credentials to do authorization.

We now have the following 3 synthesizers:

  • LegacyStackSynthesizer: asset parameters, no roles.
  • CliCredentialsStackSynthesizer: conventional assets, no roles.
  • DefaultStackSynthesizer: conventional assets, conventional roles.

(note: asset parameters, conventional roles does not seem like a
sensible option).

This will give people all the flexibility they need.

Closes #16888.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Clarify documentation of stack synthesizers a bit more, it was very
short. Also add `CliCredentialStackSynthesizer`. Many corporate users
have requested to be able to NOT use the default bootstrap roles,
because they want to rely on user credentials to do authorization.

We now have the following 3 synthesizers:

- `LegacyStackSynthesizer`: asset parameters, no roles.
- `CliCredentialsStackSynthesizer`: conventional assets, no roles.
- `DefaultStackSynthesizer`: conventional assets, conventional roles.

(note: asset parameters, conventional roles does not seem like a
sensible option).

This will give people all the flexibility they need.
@rix0rrr rix0rrr requested a review from a team February 14, 2022 15:59
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Feb 14, 2022

@rix0rrr rix0rrr self-assigned this Feb 14, 2022
@github-actions github-actions bot added the @aws-cdk/core Related to core CDK functionality label Feb 14, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 14, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 18, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: dad96ff
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a36b72b into master Feb 18, 2022
@mergify mergify bot deleted the huijbers/synthesizers branch February 18, 2022 14:13
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 18, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Clarify documentation of stack synthesizers a bit more, it was very
short. Also add `CliCredentialStackSynthesizer`. Many corporate users
have requested to be able to NOT use the default bootstrap roles,
because they want to rely on user credentials to do authorization.

We now have the following 3 synthesizers:

- `LegacyStackSynthesizer`: asset parameters, no roles.
- `CliCredentialsStackSynthesizer`: conventional assets, no roles.
- `DefaultStackSynthesizer`: conventional assets, conventional roles.

(note: asset parameters, conventional roles does not seem like a
sensible option).

This will give people all the flexibility they need.

Closes aws#16888.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/core Related to core CDK functionality contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(eks): cluster only trusts cloudformation execution role with modern synthesis

3 participants