Skip to content

chore(pipelines): clarify when not to use the modern synthesis flag#18873

Merged
mergify[bot] merged 2 commits intomasterfrom
huijbers/default-synth
Feb 8, 2022
Merged

chore(pipelines): clarify when not to use the modern synthesis flag#18873
mergify[bot] merged 2 commits intomasterfrom
huijbers/default-synth

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Feb 8, 2022

Closes #18572.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr rix0rrr requested a review from a team February 8, 2022 14:19
@rix0rrr rix0rrr self-assigned this Feb 8, 2022
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Feb 8, 2022

@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Feb 8, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 8, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 8, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 8, 2022

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 283ceaf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2d092f2 into master Feb 8, 2022
@mergify mergify bot deleted the huijbers/default-synth branch February 8, 2022 17:11
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 8, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

moelasmar pushed a commit to moelasmar/aws-cdk that referenced this pull request Feb 15, 2022
@rix0rrr @moelasmar
chore(pipelines): clarify when not to use the modern synthesis flag (a…
a336af3 
…ws#18873)

Closes aws#18572.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@rix0rrr @TikiTDO
chore(pipelines): clarify when not to use the modern synthesis flag (a…
1abac38 
…ws#18873)

Closes aws#18572.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eladb eladb eladb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rix0rrr rix0rrr

Labels

@aws-cdk/pipelines CDK Pipelines library contribution/core This is a PR that came from AWS.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(cdk-pipelines): newStyleStackSynthesis confusion

3 participants

@rix0rrr @aws-cdk-automation @eladb