chore: pin aws-sdk-mock to 5.6.0#18871
Merged
mergify[bot] merged 2 commits intoaws:masterfrom Feb 8, 2022
corymhall:corymhall/ignore-aws-sdk-mock
Merged
chore: pin aws-sdk-mock to 5.6.0#18871mergify[bot] merged 2 commits intoaws:masterfrom corymhall:corymhall/ignore-aws-sdk-mock
mergify[bot] merged 2 commits intoaws:masterfrom
corymhall:corymhall/ignore-aws-sdk-mock
Conversation
Version 5.6.1 of aws-sdk-mock introduced new types with the `@ts-ignore` annotation. The specific type in question is [this one](https://github.com/dwyl/aws-sdk-mock/blob/1a9112b81cef3b0c3fac69d8d3bb1b70c692bf3c/index.d.ts#L60) For some reason our version of `tsc` is not suppressing the type errors. I've tested with a newer version of `tsc` and the errors are suppressed. I'm not sure if this is the right thing to do here, but currently this causes our upgrade workflow to fail with the error message ``` aws-cdk: ../../node_modules/aws-sdk-mock/index.d.ts(60,90): error TS1110: Type expected. ```
|
|
rix0rrr
approved these changes
Feb 8, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
moelasmar
pushed a commit
to moelasmar/aws-cdk
that referenced
this pull request
Feb 15, 2022
Version 5.6.1 of aws-sdk-mock introduced new types with the `@ts-ignore` annotation. The specific type in question is [this one](https://github.com/dwyl/aws-sdk-mock/blob/1a9112b81cef3b0c3fac69d8d3bb1b70c692bf3c/index.d.ts#L60) For some reason our version of `tsc` is not suppressing the type errors. I've tested with a newer version of `tsc` and the errors are suppressed. I'm not sure if this is the right thing to do here, but currently this causes our upgrade workflow to fail with the error message ``` aws-cdk: ../../node_modules/aws-sdk-mock/index.d.ts(60,90): error TS1110: Type expected. ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
Version 5.6.1 of aws-sdk-mock introduced new types with the `@ts-ignore` annotation. The specific type in question is [this one](https://github.com/dwyl/aws-sdk-mock/blob/1a9112b81cef3b0c3fac69d8d3bb1b70c692bf3c/index.d.ts#L60) For some reason our version of `tsc` is not suppressing the type errors. I've tested with a newer version of `tsc` and the errors are suppressed. I'm not sure if this is the right thing to do here, but currently this causes our upgrade workflow to fail with the error message ``` aws-cdk: ../../node_modules/aws-sdk-mock/index.d.ts(60,90): error TS1110: Type expected. ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 5.6.1 of aws-sdk-mock introduced new types with the
@ts-ignoreannotation. The specific type in question is this one
For some reason our version of
tscis not suppressing the type errors.I've tested with a newer version of
tscand the errors are suppressed.I'm not sure if this is the right thing to do here, but currently this
causes our upgrade workflow to fail with the error message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license