Skip to content

chore: fix build with new jsii version#18850

Merged
mergify[bot] merged 2 commits intomasterfrom
huijbers/fix-jsii
Feb 7, 2022
Merged

chore: fix build with new jsii version#18850
mergify[bot] merged 2 commits intomasterfrom
huijbers/fix-jsii

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Feb 7, 2022

Fix some issues that break the build with either the upcoming jsii
release, or a local jsii build.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Fix some issues that break the build with either the upcoming jsii
release, or a local jsii build.
@rix0rrr rix0rrr requested review from a team and RomainMuller February 7, 2022 10:44
@rix0rrr rix0rrr self-assigned this Feb 7, 2022
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Feb 7, 2022

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 7, 2022
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
"experimentalDecorators": true,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for posterity / other people who come across this PR and wonder:

This shouldn't be necessary unless you install jsii-reflect from a local source tree (which I assume is what you did to validate this PR) without adding a project reference in tsconfig.json (because then, tsc will read the .ts files which contain a decorator -- @memoized -- instead of the .d.ts files where the decorator is stripped).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 7, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@eladb eladb mentioned this pull request Feb 7, 2022
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: b7b2c56
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c4226c7 into master Feb 7, 2022
@mergify mergify bot deleted the huijbers/fix-jsii branch February 7, 2022 13:03
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 7, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Fix some issues that break the build with either the upcoming jsii
release, or a local jsii build.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants