Skip to content

docs(cloudfront): add migration guide to modern distribution api#18835

Merged
mergify[bot] merged 5 commits intomasterfrom
peterwoodworth/docsDistributionMigration
Feb 11, 2022
Merged

docs(cloudfront): add migration guide to modern distribution api#18835
mergify[bot] merged 5 commits intomasterfrom
peterwoodworth/docsDistributionMigration

Conversation

@peterwoodworth
Copy link
Copy Markdown
Contributor

@peterwoodworth peterwoodworth commented Feb 5, 2022

Add guide for migrating from CloudFrontWebDistribution to Distribution

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Feb 5, 2022

@peterwoodworth peterwoodworth added the pr/do-not-merge This PR should not be merged at this time. label Feb 5, 2022
@github-actions github-actions bot added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label Feb 5, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 5, 2022
@peterwoodworth peterwoodworth requested a review from a team February 5, 2022 01:41
comcalvi
comcalvi approved these changes Feb 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Peter!

@peterwoodworth peterwoodworth removed the pr/do-not-merge This PR should not be merged at this time. label Feb 11, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 11, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 11, 2022

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c2ea475
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ea7802b into master Feb 11, 2022
@mergify mergify bot deleted the peterwoodworth/docsDistributionMigration branch February 11, 2022 20:56
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 11, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@robertd
Copy link
Copy Markdown
Contributor

robertd commented Feb 11, 2022

@peterwoodworth Thanks for updating the guide. For S3 origin based CF distros.... there is a ton guides out there (blogposts, etc) still promoting public S3 buckets approach and static content configuration. I'm glad to see that S3 + OAI is now being promoted as a best practice. Thanks for setting the record straight and helping folks migrate away from the old construct 👍 🥳

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@peterwoodworth @TikiTDO
docs(cloudfront): add migration guide to modern distribution api (aws…
547a26e 
…#18835)

Add guide for migrating from CloudFrontWebDistribution to Distribution

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@comcalvi comcalvi comcalvi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@comcalvi comcalvi

Labels

@aws-cdk/aws-cloudfront Related to Amazon CloudFront contribution/core This is a PR that came from AWS.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@peterwoodworth @aws-cdk-automation @robertd @comcalvi @woodwoop-ospo