docs(ec2): document how to correctly make cross stack connection calls#18796
docs(ec2): document how to correctly make cross stack connection calls#18796mergify[bot] merged 6 commits intoaws:masterfrom corymhall:corymhall/docs-sg-connections
Conversation
This PR adds documentation on how to correctly make cross stack connections. If the connection is not made in the correct stack it can lead to cyclic reference. fixes #5047
|
|
madeline-k
left a comment
There was a problem hiding this comment.
This is very helpful clarification! 😄 Just have one minor comment.
|
|
||
| // Stack 2 | ||
| const sg2 = new ec2.SecurityGroup(this, 'SG2', { | ||
| allowAllOutbound: false, // if this is `true` then no egress rule will be created |
There was a problem hiding this comment.
The examples probably should not use the same scope for sg1 and sg2, because they are supposed to be in different stacks. I think this could be confusing.
There was a problem hiding this comment.
Good point. Updated!
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws#18796) This PR adds documentation on how to correctly make cross stack connections. If the connection is not made in the correct stack it can lead to cyclic reference. fixes aws#5047 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR adds documentation on how to correctly make cross stack
connections. If the connection is not made in the correct stack it can
lead to cyclic reference.
fixes #5047
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license