Skip to content

revert: "chore(cloudfront): encryption and enforceSSL on distribution s3 loggingBucket (#18264)"#18772

Merged
mergify[bot] merged 1 commit intomasterfrom
benisrae/revert-18264
Feb 1, 2022
Merged

revert: "chore(cloudfront): encryption and enforceSSL on distribution s3 loggingBucket (#18264)"#18772
mergify[bot] merged 1 commit intomasterfrom
benisrae/revert-18264

Conversation

@eladb
Copy link
Copy Markdown
Contributor

@eladb eladb commented Feb 1, 2022

#18271 resulted in the definition of a new bucket policy, which broke existing users that already had an implicit bucket policy created by AWS (see docs).

Reverts commit ad7374a in the meantime until we figure out the longer term solution.

Fixes #18676


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Feb 1, 2022

@github-actions github-actions bot added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label Feb 1, 2022
@eladb eladb changed the title Revert "chore(cloudfront): encryption and enforceSSL on distribution … revert: "chore(cloudfront): encryption and enforceSSL on distribution s3 loggingBucket (#18264)" Feb 1, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 1, 2022
@eladb eladb requested a review from corymhall February 1, 2022 16:24
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c6cdb4d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 1, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 121e4a1 into master Feb 1, 2022
@mergify mergify bot deleted the benisrae/revert-18264 branch February 1, 2022 19:22
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
… s3 loggingBucket (aws#18264)" (aws#18772)

aws#18271 resulted in the definition of a new bucket policy, which broke existing users that already had an implicit bucket policy created by AWS (see [docs](https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/AWS-logs-and-resource-policy.html#AWS-logs-infrastructure-S3)).

Reverts commit ad7374a in the meantime until we figure out the longer term solution.

Fixes aws#18676

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
PatMyron added a commit to PatMyron/aws-cdk that referenced this pull request Feb 22, 2022
aws#18264 got reverted in:
aws#18772

because of the BucketPolicy, re-submitting the non-BucketPolicy half of that PR
mergify bot pushed a commit that referenced this pull request Mar 11, 2022
#18264 got reverted in #18772 because of the BucketPolicy, re-submitting the **_non-BucketPolicy half of that PR_**


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/aws-cloudfront Related to Amazon CloudFront contribution/core This is a PR that came from AWS.

Projects

None yet

4 participants