chore(cfnspec): outdated spec complaints on every run#18689
Merged
mergify[bot] merged 2 commits intomasterfrom Jan 27, 2022
Merged
chore(cfnspec): outdated spec complaints on every run#18689mergify[bot] merged 2 commits intomasterfrom
mergify[bot] merged 2 commits intomasterfrom
Conversation
We recently changed the cfnspec bump to always succeed, and simply record which specs have been held back because they contain errors. Except we didn't do it completely right, and now it complains on every single run about specs that are outdated, instead of only when the spec actually gets bumped. Fix that.
|
|
njlynch
approved these changes
Jan 27, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
We recently changed the cfnspec bump to always succeed, and simply record which specs have been held back because they contain errors. Except we didn't do it completely right, and now it complains on every single run about specs that are outdated, instead of only when the spec actually gets bumped. Fix that. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently changed the cfnspec bump to always succeed, and simply
record which specs have been held back because they contain errors.
Except we didn't do it completely right, and now it complains on
every single run about specs that are outdated, instead of only
when the spec actually gets bumped.
Fix that.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license