feat(logs): add QueryDefinition L2 Construct#18655
Conversation
|
|
|
Hi @comcalvi and @madeline-k Any suggested reviewer for this PR? |
|
@jerry-shao thanks for the PR, I will review this no later than next week. |
comcalvi
left a comment
There was a problem hiding this comment.
Thanks for the PR! It needs some work to further differentiate it from the L1, but this is a great start.
packages/@aws-cdk/aws-logs/test/integ.save-logs-insights-query-definition.expected.json
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-logs/test/integ.save-logs-insights-query-definition.ts
Outdated
Show resolved
Hide resolved
|
Hi @comcalvi I have added a Please take a look, thanks! |
comcalvi
left a comment
There was a problem hiding this comment.
This looks really good! I'd like to see a few quality of life changes and more uses of our existing constructs instead of raw string values, but this is coming along nicely. Nice work!
72561b0 to
e2333ab
Compare
|
Hi @comcalvi Thanks for your comments, I have addressed them in the newer commit, please take a look. Thanks! |
comcalvi
left a comment
There was a problem hiding this comment.
This looks really good! A few small comments and this should be ready to merge.
Update default attribute comment
0aba264 to
03fcd99
Compare
|
@comcalvi Thanks for your comments. I have addressed all of them, the CodeBuild should pass now :D |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR implemented the [[feature request] (aws-cloudwatch): Saved queries](aws#16395). It will let users be able to create CloudWatch Logs Insights QueryDefinition by using L2 construct. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR implemented the [feature request] (aws-cloudwatch): Saved queries. It will let users be able to create CloudWatch Logs Insights QueryDefinition by using L2 construct.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license