chore(assert): deprecate assert, assert-internal, @monocdk-experiment/assert#18634
Merged
mergify[bot] merged 3 commits intomasterfrom Jan 25, 2022
Merged
chore(assert): deprecate assert, assert-internal, @monocdk-experiment/assert#18634mergify[bot] merged 3 commits intomasterfrom
mergify[bot] merged 3 commits intomasterfrom
Conversation
|
|
skinny85
reviewed
Jan 25, 2022
| ## Replacement recommended | ||
|
|
||
| This library has been deprecated. We recommend you use the | ||
| [@aws-cdk/assertions](https://docs.aws.amazon.com/cdk/api/v1/docs/assertions-readme.html) module instead. |
Contributor
There was a problem hiding this comment.
Should we change the ReadMe of @aws-cdk/assert too, as that is actually the one used by external customers?
Contributor
Author
There was a problem hiding this comment.
The readme for the other asserts are copied directly from assert-internal
rix0rrr
approved these changes
Jan 25, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
LukvonStrom
pushed a commit
to LukvonStrom/aws-cdk
that referenced
this pull request
Jan 26, 2022
…/assert (aws#18634) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…/assert (aws#18634) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license