feat(iotevents): add grant method to Input class by yamatatsu · Pull Request #18617 · aws/aws-cdk

yamatatsu · 2022-01-23T05:06:05Z

This PR add grant method to Input class.
Next of this PR, I aim to create PR that add IoT Event Action to IoT Core Rule.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

gitpod-io · 2022-01-23T05:06:11Z

skinny85

Looks great @yamatatsu! As always 🙂. Minor notes related mostly to docs.

packages/@aws-cdk/aws-iotevents/README.md

packages/@aws-cdk/aws-iotevents/lib/input.ts

packages/@aws-cdk/aws-iotevents/test/input.test.ts

Pull request has been modified.

skinny85

Apologies I missed this @yamatatsu! A couple of minor notes/questions.

skinny85 · 2022-02-01T20:32:10Z

packages/@aws-cdk/aws-iotevents/lib/input.ts

  readonly inputName: string;
+
+  /**
+   * The ARN of the input


Suggested change

* The ARN of the input

* The ARN of the input.

I've fix all same case in aws-iotevents 👍🏻

packages/@aws-cdk/aws-iotevents/lib/input.ts

skinny85 · 2022-02-01T20:38:38Z

packages/@aws-cdk/aws-iotevents/lib/input.ts

+      grantee,
+      actions,
+      resourceArns: [this.inputArn],
+      scope: this,


Hmm. Why are we passing this argument here? I don't think it's required?

Oh. I copied from DynamoDB Table grant. I removed and confirm the test is passed.

packages/@aws-cdk/aws-iotevents/test/input.test.ts

packages/@aws-cdk/aws-iotevents/README.md

skinny85 · 2022-02-01T20:44:35Z

packages/@aws-cdk/aws-iotevents/lib/input.ts

+   *
+   * @param grantee the principal
+   */
+  grantPutMessage(grantee: iam.IGrantable): iam.Grant


What do you actually think of renaming this to grantWrite()? Maybe that's a better name, and will allow us to expand the set of granted permissions here as needed in the future?

Sound's good!

will allow us to expand the set of granted permissions here as needed in the future?

That's reasonable!

So... why is this grantPushMessage() still? 😛

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

Pull request has been modified.

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

skinny85

I think there are some merge conflicts with master that you need to solve @yamatatsu!

skinny85 · 2022-02-02T19:52:23Z

packages/@aws-cdk/aws-iotevents/lib/input.ts

+   *
+   * @param grantee the principal
+   */
+  grantPutMessage(grantee: iam.IGrantable): iam.Grant


So... why is this grantPushMessage() still? 😛

Pull request has been modified.

skinny85

Looks great @yamatatsu, thanks for the contribution!

mergify · 2022-02-03T20:23:52Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2022-02-03T21:15:33Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
Commit ID: b9bc5a7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2022-02-03T21:15:52Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

* origin/master: (27 commits) chore(eks): deprecate older versions of EKS (aws#18842) fix(tooling): update vscode devcontainer image (aws#18455) chore: npm-check-updates && yarn upgrade (aws#18832) chore(docs): Fix broken md links (aws#18384) chore(lambda-layer-awscli): install awscli with pip and requirements.txt (aws#18800) fix(aws-appsync): Strip unsupported characters from Lambda DataSource (aws#18765) feat(cfnspec): cloudformation spec v55.0.0 (aws#18827) docs(cfnspec): update CloudFormation documentation (aws#18826) chore(cxapi): plugin context provider limited by cx schema (aws#18709) feat(iotevents): add grant method to Input class (aws#18617) chore(cx-api): break circular dependencies (aws#18767) docs(core): clarify that `addOverride` does not change property casing (aws#18687) feat(s3-deployment): deploy data with deploy-time values (aws#18659) docs(cfnspec): update CloudFormation documentation (aws#18808) feat(cli): `cdk diff` works for Nested Stacks (aws#18207) docs(cfnspec): update CloudFormation documentation (aws#18783) chore(lambda-layer-awscli): add update mechanism for AWS CLI (aws#18780) chore(release): 1.143.0 feat(fsx): add support for FSx Lustre Persistent_2 deployment type (aws#18626) feat(amplify): support performance mode in Branch (aws#18598) ...

This PR add `grant` method to `Input` class. Next of this PR, I aim to create PR that add IoT Event Action to IoT Core Rule. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

feat(iotevents): add grant method to Input class

171a8ff

github-actions bot added the @aws-cdk/aws-iotevents Related to AWS IoT Events label Jan 23, 2022

github-actions bot assigned skinny85 Jan 23, 2022

yamatatsu added 3 commits January 23, 2022 15:36

fix comments

e6ca425

fix comments

8936526

Merge branch 'master' into iotevents-input-grant

87c2cc6

skinny85 previously requested changes Jan 24, 2022

View reviewed changes

address comments

69e274b

change method to init inputArn

39a1573

yamatatsu requested a review from skinny85 January 25, 2022 13:12

skinny85 previously requested changes Feb 1, 2022

View reviewed changes

yamatatsu and others added 2 commits February 2, 2022 11:59

Update packages/@aws-cdk/aws-iotevents/lib/input.ts

4764a23

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

Update packages/@aws-cdk/aws-iotevents/lib/input.ts

aa3e2b8

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

yamatatsu and others added 2 commits February 2, 2022 13:50

Update packages/@aws-cdk/aws-iotevents/README.md

af4114e

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

address comments

a8fc43d

yamatatsu requested a review from skinny85 February 2, 2022 09:43

sort test case order

0e16d84

skinny85 previously requested changes Feb 2, 2022

View reviewed changes

rename grant method

84d94db

yamatatsu added 5 commits February 3, 2022 10:39

Merge branch 'master' into iotevents-input-grant

b359bd5

fix readme

3326c73

fix readme

22e919d

fix readme

3875458

fix readme

6a4a79d

skinny85 approved these changes Feb 3, 2022

View reviewed changes

Merge branch 'master' into iotevents-input-grant

b9bc5a7

mergify bot merged commit e89688e into aws:master Feb 3, 2022

yamatatsu deleted the iotevents-input-grant branch April 6, 2022 15:17

Conversation

yamatatsu commented Jan 23, 2022

Uh oh!

gitpod-io bot commented Jan 23, 2022

Uh oh!

skinny85 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skinny85 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

skinny85 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

skinny85 left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Feb 3, 2022

Uh oh!

aws-cdk-automation commented Feb 3, 2022

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Feb 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants