Skip to content

feat(cloudwatch): add addWidget method in widget container classes#18615

Merged
mergify[bot] merged 8 commits intoaws:mainfrom
flavioleggio:feature/cloudwatch-row-widget-list
Jun 14, 2022
Merged

feat(cloudwatch): add addWidget method in widget container classes#18615
mergify[bot] merged 8 commits intoaws:mainfrom
flavioleggio:feature/cloudwatch-row-widget-list

Conversation

@flavioleggio
Copy link
Copy Markdown
Contributor

This pull request add a new addWidget method to the Row and Column classes that implement the IWidget interface by accepting other widgets as parameters (widget containers).
This is useful to programmatically add a widget to a container also after the container's construction.

Closes #18466


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch label Jan 22, 2022
@flavioleggio flavioleggio marked this pull request as draft January 22, 2022 19:04
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 22, 2022

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@flavioleggio flavioleggio changed the title feature(cloudwatch): add addWidget method in widget container classes feat(cloudwatch): add addWidget method in widget container classes Jan 22, 2022
add docs to addWidget method
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jan 22, 2022

@flavioleggio flavioleggio marked this pull request as ready for review January 26, 2022 22:31
@rix0rrr rix0rrr added feature-request A feature should be added or improved. p2 and removed p2 feature-request A feature should be added or improved. @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch labels Mar 4, 2022
@madeline-k madeline-k removed their assignment Mar 23, 2022
Copy link
Copy Markdown
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! This change looks great.

@TheRealAmazonKendra TheRealAmazonKendra changed the base branch from v1-main to main June 13, 2022 18:40
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 13, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions github-actions bot added the effort/small Small work item – less than a day of effort label Jun 13, 2022
@TheRealAmazonKendra TheRealAmazonKendra added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jun 13, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 13, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review June 13, 2022 20:33

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 13, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 398e7b6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9c31446 into aws:main Jun 14, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 14, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
…ws#18615)

This pull request add a new `addWidget` method to the `Row` and `Column` classes that implement the `IWidget` interface by accepting other widgets as parameters (widget containers).
This is useful to programmatically add a widget to a container also after the container's construction.

Closes aws#18466 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(cloudwatch): Row class to use list of widgets

5 participants