fix(stepfunctions): task token integration cannot be used with API Gateway#18595
Merged
mergify[bot] merged 9 commits intomasterfrom Jan 25, 2022
Merged
fix(stepfunctions): task token integration cannot be used with API Gateway#18595mergify[bot] merged 9 commits intomasterfrom
mergify[bot] merged 9 commits intomasterfrom
Conversation
…teway To pass the Task Token in headers to an API Gateway, the token must be wrapped in an array (because that's the value type of headers). Because JSONPath evaluation needs to happen to resolve the token, we need to use the `States.Array()` function in a `JsonPathToken` to properly resolve this. However, doing that makes the existing validation code fail the validation checking that you are passing the task token somewhere. Add convenience methods for the intrinsics, and update the checker to also find paths referenced inside intrinsic functions. Fixes #14184, fixes #14181.
|
|
9351516 to
22c439b
Compare
kaizencc
requested changes
Jan 25, 2022
Contributor
kaizencc
left a comment
There was a problem hiding this comment.
Looks good; some nits, mostly questions. And I think the intrinsics deserves mentioning in the readme.
| }); | ||
| ``` | ||
|
|
||
| Be aware that the header values must be arrays. When passing the Task Token |
Contributor
There was a problem hiding this comment.
I feel like the native intrinsic function support is a feature in itself and deserves to be mentioned in the readme too.
kaizencc
approved these changes
Jan 25, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
LukvonStrom
pushed a commit
to LukvonStrom/aws-cdk
that referenced
this pull request
Jan 26, 2022
…teway (aws#18595) To pass the Task Token in headers to an API Gateway, the token must be wrapped in an array (because that's the value type of headers). Because JSONPath evaluation needs to happen to resolve the token, we need to use the `States.Array()` function in a `JsonPathToken` to properly resolve this. However, doing that makes the existing validation code fail the validation checking that you are passing the task token somewhere. Add convenience methods for the intrinsics, and update the checker to also find paths referenced inside intrinsic functions. Fixes aws#14184, fixes aws#14181. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…teway (aws#18595) To pass the Task Token in headers to an API Gateway, the token must be wrapped in an array (because that's the value type of headers). Because JSONPath evaluation needs to happen to resolve the token, we need to use the `States.Array()` function in a `JsonPathToken` to properly resolve this. However, doing that makes the existing validation code fail the validation checking that you are passing the task token somewhere. Add convenience methods for the intrinsics, and update the checker to also find paths referenced inside intrinsic functions. Fixes aws#14184, fixes aws#14181. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To pass the Task Token in headers to an API Gateway, the token must
be wrapped in an array (because that's the value type of headers).
Because JSONPath evaluation needs to happen to resolve the token,
we need to use the
States.Array()function in aJsonPathTokento properly resolve this. However, doing that makes the existing
validation code fail the validation checking that you are passing
the task token somewhere.
Add convenience methods for the intrinsics, and update the checker
to also find paths referenced inside intrinsic functions.
Fixes #14184, fixes #14181.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license