chore(cfn-include): migrate all tests to Assertions#18537
Merged
mergify[bot] merged 10 commits intoaws:masterfrom Jan 20, 2022
Merged
chore(cfn-include): migrate all tests to Assertions#18537mergify[bot] merged 10 commits intoaws:masterfrom
mergify[bot] merged 10 commits intoaws:masterfrom
Conversation
|
|
skinny85
suggested changes
Jan 19, 2022
Contributor
skinny85
left a comment
There was a problem hiding this comment.
Looks great overall, just a few minor notes!
packages/@aws-cdk/cloudformation-include/test/valid-templates.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/cloudformation-include/test/valid-templates.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/cloudformation-include/test/valid-templates.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/cloudformation-include/test/valid-templates.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/cloudformation-include/test/valid-templates.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/cloudformation-include/test/valid-templates.test.ts
Outdated
Show resolved
Hide resolved
skinny85
reviewed
Jan 19, 2022
Contributor
skinny85
left a comment
There was a problem hiding this comment.
Overall looks great, 3 minor things.
packages/@aws-cdk/cloudformation-include/test/valid-templates.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/cloudformation-include/test/valid-templates.test.ts
Outdated
Show resolved
Hide resolved
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
kornicameister
added a commit
to kornicameister/aws-cdk
that referenced
this pull request
Jan 20, 2022
* origin/master: chore(ecr): migrate to Assertions (aws#18538) chore(codepipeline): migrate tests to assertions (aws#18545) chore(cfn-include): migrate all tests to Assertions (aws#18537) chore: move decdk to cdklabs (aws#18529) chore(cloudwatch-actions): migrate to Assertions (aws#18539) chore(globalaccelerator): migrate tests to `assertions` (aws#18532) chore(config): migrate tests to `assertions` (aws#18533) chore(docdb): migrate tests to use the Assertions module (aws#18518) chore: npm-check-updates && yarn upgrade (aws#18528)
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license