chore(ecs-patterns): migrate to Assertions#18520
Conversation
|
|
| }); | ||
|
|
||
| // THEN - stack does not contain a LaunchConfiguration | ||
| const template = SynthUtils.synthesize(stack, { skipValidation: true }); |
There was a problem hiding this comment.
This is one of the three removed tests that were all removed for the same reason. With Assertions, there is no way to skip synthesis validation (as far as I know!), so we can't do this test. And, even if we could, it seems completely pointless because a customer could never synthesize a template like this because of the validation.
Remove no-console
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
I removed 3 tests that seem pointless, but I opened an issue to investigate further: aws#18519 It really seems like the scenario they were testing (omiting the cluster and only providing vpc) is not a working scenario anyway. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
I removed 3 tests that seem pointless, but I opened an issue to investigate further: #18519
It really seems like the scenario they were testing (omiting the cluster and only providing vpc) is not a working scenario anyway.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license