Skip to content

feat(ec2): add Hpc6a instances#18445

Merged
mergify[bot] merged 3 commits intoaws:masterfrom
jumic:instance-type-hpc6a
Jan 19, 2022
Merged

feat(ec2): add Hpc6a instances#18445
mergify[bot] merged 3 commits intoaws:masterfrom
jumic:instance-type-hpc6a

Conversation

@jumic
Copy link
Copy Markdown
Contributor

@jumic jumic commented Jan 14, 2022

Add support for Hpc6a instances (high performance computing).

Announcement

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jan 14, 2022

@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Jan 14, 2022
@jumic
Copy link
Copy Markdown
Contributor Author

jumic commented Jan 14, 2022

@corymhall One of the tests introduced in #18159 failed in this build. Is it possible that two new date variables are instantiated and compared in the test? Sometimes it happens that they have different values because they are created in different seconds?

Probably the build will be successful again next time. I just wanted to show you this example. You might want to take a look.

aws-cdk: Summary of all failing tests
aws-cdk: FAIL test/api/logs/logs-monitor.test.js (11.137 s)
aws-cdk:   â—� continue to the next page if it exists
aws-cdk:     expect(received).toContain(expected) // indexOf
aws-cdk:     Expected substring: "[loggroup] 9:14:13 PM message"
aws-cdk:     Received string:    "[loggroup] 9:14:14 PM message
aws-cdk:     "
aws-cdk:       68 |     timestamp: new Date(T0 * nr * 1000).getTime(),
aws-cdk:       69 |     ingestionTime: new Date(T0 * nr * 1000).getTime(),
aws-cdk:     > 70 |   };
aws-cdk:          |     ^
aws-cdk:       71 | }
aws-cdk:       72 |
aws-cdk:       at Object.<anonymous> (test/api/logs/logs-monitor.test.ts:70:5)
aws-cdk: Test Suites: 1 failed, 49 passed, 50 total
aws-cdk: Tests:       1 failed, 416 passed, 417 total
aws-cdk: Snapshots:   0 total
aws-cdk: Time:        17.413 s
aws-cdk: Ran all test suites.

@corymhall
Copy link
Copy Markdown
Contributor

corymhall commented Jan 18, 2022

@jumic thanks for letting me know! I'll take a look.

njlynch
njlynch previously approved these changes Jan 19, 2022
View reviewed changes
@njlynch njlynch added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels Jan 19, 2022
@mergify mergify bot dismissed njlynch’s stale review January 19, 2022 11:24

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 19, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c7f39ca into aws:master Jan 19, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 19, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jan 19, 2022

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: a0da564
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@jumic @TikiTDO
feat(ec2): add Hpc6a instances (aws#18445)
0cac0e6 
Add support for Hpc6a instances (high performance computing).

[Announcement](https://aws.amazon.com/about-aws/whats-new/2022/01/amazon-ec2-hpc6a-instances/)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@njlynch njlynch njlynch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@njlynch njlynch

Labels

@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jumic @corymhall @aws-cdk-automation @njlynch