Skip to content

fix(apigateway): enabled property of ApiKeyProps is ignored#18407

Merged
mergify[bot] merged 2 commits intomasterfrom
otaviom/honor-enabled-key
Jan 14, 2022
Merged

fix(apigateway): enabled property of ApiKeyProps is ignored#18407
mergify[bot] merged 2 commits intomasterfrom
otaviom/honor-enabled-key

Conversation

@otaviomacedo
Copy link
Copy Markdown
Contributor

@otaviomacedo otaviomacedo commented Jan 13, 2022

Using nullish coalescing so that it defaults to true only if enabled is null or undefined.

Fixes #18402.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@otaviomacedo otaviomacedo requested a review from a team January 13, 2022 13:42
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jan 13, 2022

@github-actions github-actions bot added the @aws-cdk/aws-apigateway Related to Amazon API Gateway label Jan 13, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 13, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 14, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jan 14, 2022

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: fa1b038
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c31f9b4 into master Jan 14, 2022
@mergify mergify bot deleted the otaviom/honor-enabled-key branch January 14, 2022 12:51
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 14, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@otaviomacedo @TikiTDO
fix(apigateway): enabled property of ApiKeyProps is ignored (aws#…
202e6bb 
…18407)

Using nullish coalescing so that it defaults to `true` only if `enabled` is `null` or `undefined`.

Fixes aws#18402.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@njlynch njlynch njlynch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@otaviomacedo otaviomacedo

Labels

@aws-cdk/aws-apigateway Related to Amazon API Gateway contribution/core This is a PR that came from AWS.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(aws-apigateway): enabled property of ApiKeyProps is ignored

3 participants

@otaviomacedo @aws-cdk-automation @njlynch