chore(cdk-assets): fix test issue#18403
Merged
mergify[bot] merged 2 commits intomasterfrom Jan 13, 2022
Merged
Conversation
The tests were failing for me on a fresh install with:
```
[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "TypeError: sm.getSecretValue is not a function".] {
code: 'ERR_UNHANDLED_REJECTION'
}
```
There were two issues:
* `expect(...).resolves` is not a fully-formed assertion. Some assertion
needs to be made on the result of the resolution, and it nees to be
awaited.
* Due to the incomplete mocking, `sm.getSecretValue` would be a
`fn.mock` constructor, instead of an object.
I'm not sure how this ever used to work, but this fixes it.
|
|
njlynch
approved these changes
Jan 13, 2022
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
The tests were failing for me on a fresh install with:
```
[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "TypeError: sm.getSecretValue is not a function".] {
code: 'ERR_UNHANDLED_REJECTION'
}
```
There were two issues:
* `expect(...).resolves` is not a fully-formed assertion. Some assertion
needs to be made on the result of the resolution, and it nees to be
awaited.
* Due to the incomplete mocking, `sm.getSecretValue` would be a
`fn.mock` constructor, instead of an object.
I'm not sure how this ever used to work, but this fixes it.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests were failing for me on a fresh install with:
There were two issues:
expect(...).resolvesis not a fully-formed assertion. Some assertionneeds to be made on the result of the resolution, and it nees to be
awaited.
sm.getSecretValuewould be afn.mockconstructor, instead of an object.I'm not sure how this ever used to work, but this fixes it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license