chore(cli): bootstrap stack downgrading is no longer an error#18378
Merged
mergify[bot] merged 3 commits intomasterfrom Jan 12, 2022
Merged
chore(cli): bootstrap stack downgrading is no longer an error#18378mergify[bot] merged 3 commits intomasterfrom
mergify[bot] merged 3 commits intomasterfrom
Conversation
Previously, bootstrap downgrading is an error. That is, when the bootstrap stack is currently version '9', and you're trying to run `cdk bootstrap` with version '8', the command will currently fail. This makes it hard to script around, and in fact this is causing us problems in the pipeline where we unconditionally run `cdk bootstrap` and an accidentally upgraded bootstrap stack fails all tests. This is happening for no good reason, since the bootstrap stacks are backwards compatible. Turn this case from an error into a successful no-op.
|
|
otaviomacedo
approved these changes
Jan 12, 2022
Contributor
Do we have something that validates this assertion? I realize this might be a bigish effort...but I feel we should discuss this. Adding |
Contributor
Author
We definitely should. It actually doesn't have bearing on the correctness of this PR though.
⇒
|
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
) Previously, bootstrap downgrading is an error. That is, when the bootstrap stack is currently version '9', and you're trying to run `cdk bootstrap` with version '8', the command will currently fail. This makes it hard to script around, and in fact this is causing us problems in the pipeline where we unconditionally run `cdk bootstrap` and an accidentally upgraded bootstrap stack fails all tests. This is happening for no good reason, since the bootstrap stacks are backwards compatible. Turn this case from an error into a successful no-op. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, bootstrap downgrading is an error. That is, when the
bootstrap stack is currently version '9', and you're trying to run
cdk bootstrapwith version '8', the command will currently fail.This makes it hard to script around, and in fact this is causing us
problems in the pipeline where we unconditionally run
cdk bootstrapand an accidentally upgraded bootstrap stack fails all tests.
This is happening for no good reason, since the bootstrap stacks are
backwards compatible.
Turn this case from an error into a successful no-op.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license