Skip to content

feat(lambda-nodejs): ES modules#18346

Merged
mergify[bot] merged 4 commits intoaws:masterfrom
jogold:nodejs-esm
Jan 11, 2022
Merged

feat(lambda-nodejs): ES modules#18346
mergify[bot] merged 4 commits intoaws:masterfrom
jogold:nodejs-esm

Conversation

@jogold
Copy link
Copy Markdown
Contributor

@jogold jogold commented Jan 10, 2022

Add a format option to choose the output format (CommonJS or
ECMAScript module).

Generate a index.mjs file when the ECMAScript module output format
is chosen so that AWS Lambda treats it correctly.

See https://aws.amazon.com/about-aws/whats-new/2022/01/aws-lambda-es-modules-top-level-await-node-js-14/
See https://aws.amazon.com/blogs/compute/using-node-js-es-modules-and-top-level-await-in-aws-lambda/

Closes #13274


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Add a `format` option to choose the output format (CommonJS or
ECMAScript module).

Generate a `index.mjs` file when the ECMAScript module output format
is chosen so that AWS Lambda treats it correctly.

Closes aws#13274
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jan 10, 2022

@mergify mergify bot dismissed corymhall’s stale review January 11, 2022 13:34

Pull request has been modified.

@jogold jogold requested a review from corymhall January 11, 2022 13:34
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 11, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: bad4eb1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e23b63f into aws:master Jan 11, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 11, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Add a `format` option to choose the output format (CommonJS or
ECMAScript module).

Generate a `index.mjs` file when the ECMAScript module output format
is chosen so that AWS Lambda treats it correctly.

See https://aws.amazon.com/about-aws/whats-new/2022/01/aws-lambda-es-modules-top-level-await-node-js-14/
See https://aws.amazon.com/blogs/compute/using-node-js-es-modules-and-top-level-await-in-aws-lambda/

Closes aws#13274

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(aws-lambda-nodejs): .mjs file extension and import.meta not supported

3 participants