fix(cli): breaks due to faulty version of colors#18324
Merged
mergify[bot] merged 2 commits intoaws:masterfrom Jan 9, 2022
SheaBelsky:sheabelsky_pinColorsDependency
Merged
fix(cli): breaks due to faulty version of colors#18324mergify[bot] merged 2 commits intoaws:masterfrom SheaBelsky:sheabelsky_pinColorsDependency
colors#18324mergify[bot] merged 2 commits intoaws:masterfrom
SheaBelsky:sheabelsky_pinColorsDependency
Conversation
|
|
Contributor
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
|
Keep in mind that lockfiles might not workwhen packages are globally installed. |
|
that locks down the version for all deeply nested dependencies: https://classic.yarnpkg.com/lang/en/docs/selective-version-resolutions/ npm users might need also https://www.npmjs.com/package/npm-force-resolutions |
|
Adding "resolutions": { "colors": "1.4.0" }to my |
colors
colorscolors
iliapolo
approved these changes
Jan 9, 2022
Contributor
iliapolo
left a comment
There was a problem hiding this comment.
@SheaBelsky Thanks for this!
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
iliapolo
pushed a commit
that referenced
this pull request
Jan 9, 2022
Fixes #18322 and #18323 Clarifying question: I'm not sure if the `yarn.lock` file should have automatically updated itself to only refer to `colors@1.4.0` when I set the dependency within the workspace _and_ added the resolution for child dependencies. If it's expected behavior for it _not_ to update the `yarn.lock` file after adding `resolutions`, great! If I need to do something else for that to happen, let me know! ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
iliapolo
pushed a commit
that referenced
this pull request
Jan 9, 2022
Fixes #18322 and #18323 Clarifying question: I'm not sure if the `yarn.lock` file should have automatically updated itself to only refer to `colors@1.4.0` when I set the dependency within the workspace _and_ added the resolution for child dependencies. If it's expected behavior for it _not_ to update the `yarn.lock` file after adding `resolutions`, great! If I need to do something else for that to happen, let me know! ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot
pushed a commit
that referenced
this pull request
Jan 9, 2022
Forward merging #18324 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
2 tasks
4 tasks
Contributor
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
Fixes aws#18322 and aws#18323 Clarifying question: I'm not sure if the `yarn.lock` file should have automatically updated itself to only refer to `colors@1.4.0` when I set the dependency within the workspace _and_ added the resolution for child dependencies. If it's expected behavior for it _not_ to update the `yarn.lock` file after adding `resolutions`, great! If I need to do something else for that to happen, let me know! ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18322 and #18323
Clarifying question: I'm not sure if the
yarn.lockfile should have automatically updated itself to only refer tocolors@1.4.0when I set the dependency within the workspace and added the resolution for child dependencies. If it's expected behavior for it not to update theyarn.lockfile after addingresolutions, great! If I need to do something else for that to happen, let me know!By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license