Skip to content

chore: throw more descriptive error when failing to create output directory#18296

Merged
mergify[bot] merged 5 commits intoaws:masterfrom
adamnovak:patch-1
Mar 30, 2022
Merged

chore: throw more descriptive error when failing to create output directory#18296
mergify[bot] merged 5 commits intoaws:masterfrom
adamnovak:patch-1

Conversation

@adamnovak
Copy link
Copy Markdown
Contributor

@adamnovak adamnovak commented Jan 6, 2022

I passed a --output to the CDK that was /public/something/or/other, on a system with no /public, and then forgot about it. I was presented with the head-scratch-inducing failure message:

ENOENT: no such file or directory, mkdir '/public'
Error: ENOENT: no such file or directory, mkdir '/public'

This should improve the error so that some reference is made to why the CDK expects or desires this path to exist (and remind me that in fact I told it to go there).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Jan 6, 2022

@github-actions github-actions bot added the @aws-cdk/region-info Related to AWS Region information label Jan 6, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 6, 2022

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@adamnovak adamnovak changed the title Complain intelligibly about bad output directories feat: complain intelligibly about bad output directories Jan 18, 2022
@rix0rrr rix0rrr changed the title feat: complain intelligibly about bad output directories chore: complain intelligibly about bad output directories Mar 30, 2022
@github-actions github-actions bot added the p2 label Mar 30, 2022
@rix0rrr rix0rrr changed the title chore: complain intelligibly about bad output directories chore: throw more descriptive error when failing to create output directory Mar 30, 2022
rix0rrr
rix0rrr previously approved these changes Mar 30, 2022
@mergify mergify bot dismissed rix0rrr’s stale review March 30, 2022 19:37

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 30, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: f447b9d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit fbba9c7 into aws:master Mar 30, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 30, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

StevePotter pushed a commit to StevePotter/aws-cdk that referenced this pull request Apr 27, 2022
…ectory (aws#18296)

I passed a `--output` to the CDK that was `/public/something/or/other`, on a system with no `/public`, and then forgot about it. I was presented with the head-scratch-inducing failure message:

```
ENOENT: no such file or directory, mkdir '/public'
Error: ENOENT: no such file or directory, mkdir '/public'
```

This should improve the error so that some reference is made to why the CDK expects or desires this path to exist (and remind me that in fact I told it to go there).

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/region-info Related to AWS Region information p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants