fix(appmesh): allow a Virtual Node have as a backend a Virtual Service whose provider is that Node#18265
Conversation
|
|
c3a5157 to
175140d
Compare
skinny85
left a comment
There was a problem hiding this comment.
Looks good @wplucinsky! A few minor comments.
Additionally, the build is failing - looks like you need to update an integ test in the @aws-cdk-containers/ecs-service-extensions module:
@aws-cdk-containers/ecs-service-extensions: Verifying integ.all-service-addons.js against integ.all-service-addons.expected.json ... CHANGED.
|
Thanks @wplucinsky and @skinny85! These are looking great! |
175140d to
98c481c
Compare
|
@wplucinsky - This is the friendly reminder that the build is failing for the
Above was totally wrong assumption. Sorry for adding the confusion. |
98c481c to
a54c39a
Compare
…e reference for virtual node backends
skinny85
left a comment
There was a problem hiding this comment.
Looks perfect, thanks @wplucinsky!
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…e whose provider is that Node (aws#18265) Addresses a circular dependency issue between Virtual Nodes and Virtual Services that works for Virtual Services created with a defined `virtualServiceName` and a randomly generated name. One such example of this problem was a case where a Virtual Node had a backend that is a Virtual Service whose provider was given as the same Virtual Node. This led to the Virtual Node being dependent on the creation of the Virtual Service, and the Virtual Service being dependent on the creation of the Virtual Node. Fixes aws#17322 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Addresses a circular dependency issue between Virtual Nodes and Virtual Services that works for Virtual Services created with a defined
virtualServiceNameand a randomly generated name.One such example of this problem was a case where a Virtual Node had a backend that is a Virtual Service whose provider was given as the same Virtual Node. This led to the Virtual Node being dependent on the creation of the Virtual Service, and the Virtual Service being dependent on the creation of the Virtual Node.
Fixes #17322
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license