fix(core): Duration.toString() throws an error#18243
Merged
mergify[bot] merged 5 commits intomasterfrom Jan 3, 2022
Merged
Conversation
`Duration.toString()` shouldn't throw an exception directly--instead, it should produce an encoded token that throws when resolved. The reason it was throwing is that `Token.asString()` doesn't accept functions, it only accepts data values. Use `Lazy.string()` instead. Fixes #18176.
|
|
eladb
reviewed
Jan 3, 2022
| }); | ||
|
|
||
| test('can stringify but not resolve', () => { | ||
| const stringified = `${Duration.hours(1)}`; |
Contributor
There was a problem hiding this comment.
Perhaps it makes more sense to simply return a string representation of the duration (eg "1 hour" or even just ״<duration>").
Contributor
Author
There was a problem hiding this comment.
You are saying get rid of the misuse protection because it's not worth it, right?
…nto huijbers/duration-tostring
eladb
approved these changes
Jan 3, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
`Duration.toString()` was intended to produce a value that would throw an exception when resolved, but unintentionally was written to always throw immediately (the reason it was throwing is that `Token.asString()` doesn't accept functions, it only accepts data values--`Lazy.string()` should have been used). Instead, we remove the validation completely. `toString()` now produces a meaningless string, and users should avoid using the `Duration` object in a context where it will be implicitly converted to a string. Fixes aws#18176. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duration.toString()was intended to produce a value that would throw an exception when resolved,but unintentionally was written to always throw immediately (the reason it was throwing is that
Token.asString()doesn't accept functions, it only accepts data values--
Lazy.string()should have been used).Instead, we remove the validation completely.
toString()now produces a meaningless string, and usersshould avoid using the
Durationobject in a context where it will be implicitly converted to a string.Fixes #18176.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license