feat(cli): show how long cdk deploy steps take #18230
Conversation
|
|
skinny85
left a comment
There was a problem hiding this comment.
Looks great @kaizen3031593!
Two minor comments / questions.
packages/aws-cdk/lib/cdk-toolkit.ts
Outdated
| }); | ||
| } | ||
| } | ||
| print('\n✨ Total time: %ss', roundPercentage((elapsedSynthTime + elapsedDeployTime) / 1000)); |
There was a problem hiding this comment.
I notice that the synth time has a newline at the end, but neither deploy time nor total time do. Is that an intentional difference between them?
There was a problem hiding this comment.
added newline to both. I like the clarity of an extra new line, and originally deploy did not have it because the following print statements began with a \n whereas the ones after synth did not. However, I see this as an opportunity to remove those extraneous new lines.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
skinny85
left a comment
There was a problem hiding this comment.
Looks great @kaizen3031593!
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Keeps track of how long `cdk deploy` steps take. Times synthesis time along with actual deploy time. Result is something like this:  No tests because all I'm adding is print statements. Closes aws#18213. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Keeps track of how long
cdk deploysteps take. Times synthesis time along with actual deploy time.Result is something like this:
No tests because all I'm adding is print statements.
Closes #18213.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license