fix(logs): respect region when importing log group#18215
fix(logs): respect region when importing log group#18215mergify[bot] merged 9 commits intoaws:masterfrom
Conversation
When log group is imported it is crucial to preserve an information about region where log group exists. Without that information it is not possible to implement cross region logging. fixes aws#18214
|
|
|
@comcalvi what has changed in master setup that build here fails? |
skinny85
left a comment
There was a problem hiding this comment.
Looks good @kornicameister! One comment about the test.
skinny85
left a comment
There was a problem hiding this comment.
Looks great @kornicameister! A few tiny changes that I'll apply myself.
skinny85
left a comment
There was a problem hiding this comment.
Thanks for the fix @kornicameister!
|
LOL, I was just trying to pushfixes for your comments @skinny85 and been wondering why commit is rejected :D |
|
Anyway, I've just made a PR and fix is actually on you @skinny85 . I wouldn't be so fast if you didn't tell me exact API portion to look at. So thanks and cheers to you ! 👍 |
|
My pleasure @kornicameister, but you did do a lot of work, it definitely wasn't just me. It was a good collaboration 🙂. |
Likewise :-) |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
When log group is imported it is crucial to preserve an information about region where log group exists. Without that information it is not possible to implement cross region logging. fixes aws#18214 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
When log group is imported it is crucial to preserve an information
about region where log group exists. Without that information it is not possible
to implement cross region logging.
fixes #18214
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license