chore(cfnspec): consume CloudFormation specification in parts#18210
Merged
mergify[bot] merged 7 commits intomasterfrom Jan 4, 2022
Merged
chore(cfnspec): consume CloudFormation specification in parts#18210mergify[bot] merged 7 commits intomasterfrom
mergify[bot] merged 7 commits intomasterfrom
Conversation
Whenever there are errors in the CloudFormation specification, we currently have to fail the build and can't consume anything. To ensure we make some progress, apply the following strategy instead: - Split the spec into fragments, on a per-service basis. - Consume those per-service spec updates that are valid; if updates are invalid, we will leave them at the old version. This will produce an always-building spec, of which certain parts may be outdated. Report the outdated parts in the CHANGELOG. Notifying the CloudFormation team about spec errors is an out-of-band process, and out of scope of this PR. As a side effect of this work, formalize the spec manipulation we do with JSON and patch files into a mini-standard called "JSON Patch Stacks", and add some tools to operate on them.
|
|
njlynch
suggested changes
Dec 29, 2021
Contributor
njlynch
left a comment
There was a problem hiding this comment.
Looks good!
This is a good bit of new code, but no new tests. :( Some baseline tests so someone modifying this in the future knows they likely haven't horked it would be nifty.
Also, the build is currently failing. :)
njlynch
reviewed
Jan 4, 2022
| throw new Error(`Attempted to merge ${JSON.stringify(fragVal)} into incompatible ${JSON.stringify(specVal)} at path ${jsonPath.join('/')}/${key}`); | ||
| } | ||
| if (typeof specVal !== 'object' && specVal !== fragVal) { | ||
| if (specVal == fragVal) { |
Contributor
There was a problem hiding this comment.
Intentional ==, or intended to be ===?
njlynch
approved these changes
Jan 4, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
) Whenever there are errors in the CloudFormation specification, we currently have to fail the build and can't consume anything. To ensure we make some progress, apply the following strategy instead: - Split the spec into fragments, on a per-service basis. - Consume those per-service spec updates that are valid; if updates are invalid, we will leave them at the old version. This will produce an always-building spec, of which certain parts may be outdated. Report the outdated parts in the CHANGELOG. Notifying the CloudFormation team about spec errors is an out-of-band process, and out of scope of this PR. As a side effect of this work, formalize the spec manipulation we do with JSON and patch files into a mini-standard called "JSON Patch Stacks", and add some tools to operate on them. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever there are errors in the CloudFormation specification, we
currently have to fail the build and can't consume anything.
To ensure we make some progress, apply the following strategy instead:
are invalid, we will leave them at the old version.
This will produce an always-building spec, of which certain parts
may be outdated. Report the outdated parts in the CHANGELOG.
Notifying the CloudFormation team about spec errors is an out-of-band
process, and out of scope of this PR.
As a side effect of this work, formalize the spec manipulation we do
with JSON and patch files into a mini-standard called "JSON Patch
Stacks", and add some tools to operate on them.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license