Skip to content

chore(cfnspec): CloudFormation documentation in L1 classes, again#18190

Merged
mergify[bot] merged 2 commits intomasterfrom
huijbers/cfn-docs-take-2
Dec 27, 2021
Merged

chore(cfnspec): CloudFormation documentation in L1 classes, again#18190
mergify[bot] merged 2 commits intomasterfrom
huijbers/cfn-docs-take-2

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Dec 27, 2021

Re-draft of #18101. The previous implementation rendered invalid
escape sequences which would break the Java rendering.

Fixed in this iteration.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Re-draft of #18101. The previous implementation rendered invalid
escape sequences which would break the Java rendering.

Fixed in this iteration.
@rix0rrr rix0rrr requested a review from a team December 27, 2021 17:09
@rix0rrr rix0rrr self-assigned this Dec 27, 2021
@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Dec 27, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 27, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 27, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: f189194
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a15250e into master Dec 27, 2021
@mergify mergify bot deleted the huijbers/cfn-docs-take-2 branch December 27, 2021 19:36
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 27, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…s#18190)

Re-draft of aws#18101. The previous implementation rendered invalid
escape sequences which would break the Java rendering.

Fixed in this iteration.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/cfnspec contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants