chore(yarn-cling): breaks on dependency cycle#18188
Merged
mergify[bot] merged 1 commit intomasterfrom Dec 27, 2021
Merged
Conversation
In a recent upgrade, one of our dependencies (`json-diff`) has taken a dependency on a cluster of packages that have dependency cycles between them. Specifically: ``` json-diff => cli-color => [ d => es5-ext => es6-iterator => d ]. json-diff => cli-color => d => [ es5-ext => es6-iterator => es5-ext ]. json-diff => cli-color => [ d => es5-ext => es6-iterator => es6-symbol => d ]. json-diff => cli-color => [ d => es5-ext => es6-symbol => d ]. json-diff => cli-color => [ es5-ext => es6-iterator => d => es5-ext ]. json-diff => cli-color => [ es5-ext => es6-iterator => es6-symbol => d => es5-ext ]. json-diff => cli-color => [ es5-ext => es6-symbol => d => es5-ext ]. json-diff => cli-color => [ es6-iterator => d => es5-ext => es6-iterator ]. json-diff => cli-color => [ es6-iterator => es5-ext => es6-iterator ]. json-diff => cli-color => [ es6-iterator => es6-symbol => d => es5-ext => es6-iterator ]. json-diff => cli-color => es6-iterator => [ es6-symbol => d => es5-ext => es6-symbol ]. json-diff => cli-color => memoizee => es6-weak-map => [ es6-symbol => d => es5-ext => es6-iterator => es6-symbol ]. ``` `yarn-cling` used to go into infinite recursion trying to resolve this dependency tree, as it was not prepared to handle cycles. Add a dependency breaker. Since I wasn't sure whether or not this might break the dependency tree, add a validation step as well.
|
|
iliapolo
approved these changes
Dec 27, 2021
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
In a recent upgrade, one of our dependencies (`json-diff`) has taken a dependency on a cluster of packages that have dependency cycles between them. Specifically: ``` json-diff => cli-color => [ d => es5-ext => es6-iterator => d ]. json-diff => cli-color => d => [ es5-ext => es6-iterator => es5-ext ]. json-diff => cli-color => [ d => es5-ext => es6-iterator => es6-symbol => d ]. json-diff => cli-color => [ d => es5-ext => es6-symbol => d ]. json-diff => cli-color => [ es5-ext => es6-iterator => d => es5-ext ]. json-diff => cli-color => [ es5-ext => es6-iterator => es6-symbol => d => es5-ext ]. json-diff => cli-color => [ es5-ext => es6-symbol => d => es5-ext ]. json-diff => cli-color => [ es6-iterator => d => es5-ext => es6-iterator ]. json-diff => cli-color => [ es6-iterator => es5-ext => es6-iterator ]. json-diff => cli-color => [ es6-iterator => es6-symbol => d => es5-ext => es6-iterator ]. json-diff => cli-color => es6-iterator => [ es6-symbol => d => es5-ext => es6-symbol ]. json-diff => cli-color => memoizee => es6-weak-map => [ es6-symbol => d => es5-ext => es6-iterator => es6-symbol ]. ``` `yarn-cling` used to go into infinite recursion trying to resolve this dependency tree, as it was not prepared to handle cycles. Add a dependency breaker. Since I wasn't sure whether or not this might break the dependency tree, add a validation step as well. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a recent upgrade, one of our dependencies (
json-diff) has takena dependency on a cluster of packages that have dependency cycles
between them. Specifically:
yarn-clingused to go into infinite recursion trying to resolve thisdependency tree, as it was not prepared to handle cycles.
Add a dependency breaker. Since I wasn't sure whether or not this
might break the dependency tree, add a validation step as well.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license