Skip to content

chore: rename label for auto approvals#18183

Merged
mergify[bot] merged 1 commit intomasterfrom
epolon/auto-approve-label
Dec 26, 2021
Merged

chore: rename label for auto approvals#18183
mergify[bot] merged 1 commit intomasterfrom
epolon/auto-approve-label

Conversation

@iliapolo
Copy link
Copy Markdown
Contributor

The current label (pr/auto-approve) doesn't match the default label that projen uses (auto-approve).

Our repository monitoring mechanisms use pr/auto-approve to detect stale PR's, while this is OK for the jsii and aws-cdk repositories, its not for basically all other repo's, since they are managed by projen.

So we need to change the label our monitoring uses to auto-approve, this PR is a preparation for that, so we don't loose monitoring of this repo.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Dec 26, 2021

@iliapolo iliapolo requested a review from eladb December 26, 2021 11:52
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 26, 2021
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 3f3aeec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 17fc011 into master Dec 26, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the epolon/auto-approve-label branch December 26, 2021 13:54
mergify bot pushed a commit to aws/jsii that referenced this pull request Dec 26, 2021
See aws/aws-cdk#18183

---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
The current label (`pr/auto-approve`) doesn't match the default label that `projen` uses (`auto-approve`). 

Our repository monitoring mechanisms use `pr/auto-approve` to detect stale PR's, while this is OK for the `jsii` and `aws-cdk` repositories, its not for basically all other repo's, since they are managed by projen. 

So we need to change the label our monitoring uses to `auto-approve`, this PR is a preparation for that, so we don't loose monitoring of this repo.  

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants