Skip to content

revert(cfnspec): add CloudFormation documentation to L1 classes#18177

Merged
mergify[bot] merged 2 commits intomasterfrom
epolon/revert-cfn-docs
Dec 26, 2021
Merged

revert(cfnspec): add CloudFormation documentation to L1 classes#18177
mergify[bot] merged 2 commits intomasterfrom
epolon/revert-cfn-docs

Conversation

@iliapolo
Copy link
Copy Markdown
Contributor

This reverts commit 0ed661d.

Its currently failing our pipeline with:

#STDOUT> [INFO] Total time:  08:11 min
--
958 | #STDOUT> [INFO] Finished at: 2021-12-25T02:10:45Z
959 | #STDOUT> [INFO] ------------------------------------------------------------------------
960 | #STDOUT> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project lex: Compilation failure: Compilation failure:
961 | #STDOUT> [ERROR] /tmp/npm-packDT4j4g/_aws-cdk_aws-lex/src/main/java/software/amazon/awscdk/services/lex/CfnBot.java:[11584,39] illegal unicode escape
962 | #STDOUT> [ERROR] /tmp/npm-packDT4j4g/_aws-cdk_aws-lex/src/main/java/software/amazon/awscdk/services/lex/CfnBot.java:[13,1] illegal unicode escape
963 | #STDOUT> [ERROR] /tmp/npm-packDT4j4g/_aws-cdk_aws-lex/src/main/java/software/amazon/awscdk/services/lex/CfnBot.java:[11621,58] illegal unicode escape
964 | #STDOUT> [ERROR] /tmp/npm-packDT4j4g/_aws-cdk_aws-lex/src/main/java/software/amazon/awscdk/services/lex/CfnBot.java:[17,32] illegal unicode escape

Looks like the docs are adding some illegal characters.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Dec 25, 2021

@iliapolo
Copy link
Copy Markdown
Contributor Author

FYI @rix0rrr, leaving the investigation to you :)

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 25, 2021
@iliapolo iliapolo requested review from a team and eladb December 25, 2021 18:06
@iliapolo
Copy link
Copy Markdown
Contributor Author

Putting this on hold for now since we believe there's an easy fix forward.

@iliapolo iliapolo marked this pull request as draft December 26, 2021 11:15
@iliapolo
Copy link
Copy Markdown
Contributor Author

Looks like we have some wild characters out there, reverting until we catch them.

@iliapolo iliapolo marked this pull request as ready for review December 26, 2021 13:23
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 4489eaa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2530016 into master Dec 26, 2021
@mergify mergify bot deleted the epolon/revert-cfn-docs branch December 26, 2021 15:03
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…18177)

This reverts commit 0ed661d.

Its currently failing our pipeline with:

```console
#STDOUT> [INFO] Total time:  08:11 min
--
958 | #STDOUT> [INFO] Finished at: 2021-12-25T02:10:45Z
959 | #STDOUT> [INFO] ------------------------------------------------------------------------
960 | #STDOUT> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project lex: Compilation failure: Compilation failure:
961 | #STDOUT> [ERROR] /tmp/npm-packDT4j4g/_aws-cdk_aws-lex/src/main/java/software/amazon/awscdk/services/lex/CfnBot.java:[11584,39] illegal unicode escape
962 | #STDOUT> [ERROR] /tmp/npm-packDT4j4g/_aws-cdk_aws-lex/src/main/java/software/amazon/awscdk/services/lex/CfnBot.java:[13,1] illegal unicode escape
963 | #STDOUT> [ERROR] /tmp/npm-packDT4j4g/_aws-cdk_aws-lex/src/main/java/software/amazon/awscdk/services/lex/CfnBot.java:[11621,58] illegal unicode escape
964 | #STDOUT> [ERROR] /tmp/npm-packDT4j4g/_aws-cdk_aws-lex/src/main/java/software/amazon/awscdk/services/lex/CfnBot.java:[17,32] illegal unicode escape
```

Looks like the docs are adding some illegal characters. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/cfnspec contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants