chore: don't bump empty releases#18151
Merged
mergify[bot] merged 1 commit intomasterfrom Dec 23, 2021
Merged
Conversation
v2.3.0 was an empty release compared to v2.2.0, because the forward merge had been failing. It's pointless to release an empty release, so have the bump script check for this situation, and not do anything. Slightly complicated from the obvious logic which would only check commit history: in practice the merge-back commit gets added on top. So we check the actual file changes since the previous release.
|
|
RomainMuller
approved these changes
Dec 23, 2021
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
v2.3.0 was an empty release compared to v2.2.0, because the forward merge had been failing. It's pointless to release an empty release, so have the bump script check for this situation, and not do anything. Slightly complicated from the obvious logic which would only check commit history: in practice the merge-back commit gets added on top. So we check the actual file changes since the previous release. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v2.3.0 was an empty release compared to v2.2.0, because the forward
merge had been failing.
It's pointless to release an empty release, so have the bump script
check for this situation, and not do anything.
Slightly complicated from the obvious logic which would only check
commit history: in practice the merge-back commit gets added on
top. So we check the actual file changes since the previous release.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license