Merged
Conversation
|
|
kaizencc
commented
Dec 21, 2021
pack.sh
Outdated
|
|
||
| # Jsii packaging (all at once using jsii-pacmak) | ||
| echo "Packaging jsii modules" >&2 | ||
| rosetta_cache_file=$HOME/.s3buildcache/rosetta-cache.tabl.json |
Contributor
Author
There was a problem hiding this comment.
should this be an environment variable instead? currently I just copied and pasted from run-rosetta and it seems fragile.
rix0rrr
approved these changes
Dec 22, 2021
Contributor
rix0rrr
left a comment
There was a problem hiding this comment.
Provisional approval, upon addressing these issues and the investigation work you're going to be doing
eed7551 to
0729dfa
Compare
Contributor
Author
|
The test pipeline is working for this commit, so I'm going to go ahead and merge. |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
This point of this PR is to streamline the docs build in `run-rosetta.sh`. We now utilize the npm package [`cdk-generate-synthetic-examples`](https://github.com/cdklabs/cdk-generate-synthetic-examples) owned by yours truly. We also run `rosetta extract` twice, to properly translate generated examples. We purposefully ignore infused examples for this step. In addition, we remove the `generate-examples` project ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This point of this PR is to streamline the docs build in
run-rosetta.sh. We nowutilize the npm package
cdk-generate-synthetic-examplesowned by yours truly.We also run
rosetta extracttwice, to properly translate generated examples. We purposefully ignore infused examples for this step.In addition, we remove the
generate-examplesprojectBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license