feat(aws-kinesis): add support for data streams capacity modes#18074
Merged
mergify[bot] merged 5 commits intoaws:masterfrom Dec 20, 2021
igilham:kinesis-modes
Merged
feat(aws-kinesis): add support for data streams capacity modes#18074mergify[bot] merged 5 commits intoaws:masterfrom igilham:kinesis-modes
mergify[bot] merged 5 commits intoaws:masterfrom
igilham:kinesis-modes
Conversation
|
|
Add support for Kinesis Data Streams capacity modes. Fixes #18050
otaviomacedo
previously requested changes
Dec 18, 2021
Co-authored-by: Otavio Macedo <otaviomacedo@protonmail.com>
Pull request has been modified.
- Rename StreamModeDetails to StreamMode - Improve enum docs
Reduce boilerplate around setting stream mode in CfnStream
otaviomacedo
approved these changes
Dec 20, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…8074) The latest CloudFormation spec (v51) added support for selecting a capacity mode for Kinesis Data Streams. This is already supported by the generated L1 construct. This change adds support for the feature to the L2 construct class `Stream` via the constructor props `StreamProps`. closes aws#18050 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest CloudFormation spec (v51) added support for selecting a capacity mode for Kinesis Data Streams. This is already supported by the generated L1 construct. This change adds support for the feature to the L2 construct class
Streamvia the constructor propsStreamProps.closes #18050
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license