fix(aws-lambda-nodejs): pre compilation with tsc is not being run#18062
Merged
mergify[bot] merged 9 commits intoaws:masterfrom Jan 28, 2022
Merged
fix(aws-lambda-nodejs): pre compilation with tsc is not being run#18062mergify[bot] merged 9 commits intoaws:masterfrom
mergify[bot] merged 9 commits intoaws:masterfrom
Conversation
|
|
|
Any updates on this? |
Contributor
Author
I was really busy for quite some time and did not have a chance to work on this further, but I'll surely work on this over the coming weekend, Thanks for your patience! |
4324785 to
e81c46f
Compare
e81c46f to
f2a10ec
Compare
jogold
reviewed
Jan 18, 2022
Contributor
|
@corymhall this is good to go! |
jogold
approved these changes
Jan 28, 2022
corymhall
approved these changes
Jan 28, 2022
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…s#18062) Revamped the logic of running `tsc`, previously we were running `tsc` once for the whole project and due to this logic, `tsc` was not running as on the first run as `createBundlingCommand` first prepare command to execute on Docker and then for local bundling and on the first run we already updated the flag to not run `tsc` now. Closes [aws#18002](aws#18002) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revamped the logic of running
tsc, previously we were runningtsconce for the whole project and due to this logic,tscwas not running as on the first run ascreateBundlingCommandfirst prepare command to execute on Docker and then for local bundling and on the first run we already updated the flag to not runtscnow.Closes #18002
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license