Skip to content

chore(core): Pass Lambda Context to custom resource handler#18056

Merged
mergify[bot] merged 3 commits intoaws:masterfrom
JeffSidedDie:customer-resource-provider-lambda-context-fix
Jan 3, 2022
Merged

chore(core): Pass Lambda Context to custom resource handler#18056
mergify[bot] merged 3 commits intoaws:masterfrom
JeffSidedDie:customer-resource-provider-lambda-context-fix

Conversation

@JeffSidedDie
Copy link
Copy Markdown
Contributor

… passing context object into user handler.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Fixes #18055

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Dec 16, 2021

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 16, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Dec 16, 2021
@JeffSidedDie JeffSidedDie changed the title Added Lambda context object to CustomResourceProvider entry point and… fix(core): Added Lambda context object to CustomResourceProvider entry point and… Dec 16, 2021
@github-actions github-actions bot added the @aws-cdk/core Related to core CDK functionality label Dec 16, 2021
@kaizencc kaizencc removed the @aws-cdk/aws-lambda Related to AWS Lambda label Dec 29, 2021
@kaizencc kaizencc removed their assignment Dec 29, 2021
@rix0rrr rix0rrr changed the title fix(core): Added Lambda context object to CustomResourceProvider entry point and… chore(core): Pass Lambda Context to custom resource entrypoint Jan 3, 2022
@rix0rrr rix0rrr changed the title chore(core): Pass Lambda Context to custom resource entrypoint chore(core): Pass Lambda Context to custom resource handler Jan 3, 2022
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned, you should probably not be using this custom resource provider, but instead use the one from the custom-resources module.

At the same time, I don't see a good reason not to add this parameter, so in it goes.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 3, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 5ab0e11
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2868f1d into aws:master Jan 3, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 3, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
… passing context object into user handler.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Fixes aws#18055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/core Related to core CDK functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(core): CustomResourceProvider entrypoint does not pass Lambda context object

4 participants