Skip to content

feat(codepipeline): add ability to not reuse cross-region support Stacks#18043

Merged
mergify[bot] merged 8 commits intoaws:masterfrom
tobytipton:crossRegionSupportStack
Dec 17, 2021
Merged

feat(codepipeline): add ability to not reuse cross-region support Stacks#18043
mergify[bot] merged 8 commits intoaws:masterfrom
tobytipton:crossRegionSupportStack

Conversation

@tobytipton
Copy link
Copy Markdown
Contributor

@tobytipton tobytipton commented Dec 15, 2021

This provides the change proposed in feature request #18018 by adding the new flag.

closes #18018

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Dec 15, 2021

@github-actions github-actions bot added the @aws-cdk/aws-codepipeline Related to AWS CodePipeline label Dec 15, 2021
skinny85
skinny85 previously requested changes Dec 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @tobytipton! A few minor comments before we merge this in.

@mergify mergify bot dismissed skinny85’s stale review December 16, 2021 14:15

Pull request has been modified.

skinny85
skinny85 reviewed Dec 16, 2021
View reviewed changes
skinny85
skinny85 previously approved these changes Dec 16, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @tobytipton!

@mergify mergify bot dismissed skinny85’s stale review December 16, 2021 19:07

Pull request has been modified.

skinny85
skinny85 previously approved these changes Dec 16, 2021
View reviewed changes
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 16, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@tobytipton
Copy link
Copy Markdown
Contributor Author

tobytipton commented Dec 16, 2021

Looks like the build failed for aws-logs?

@skinny85
Copy link
Copy Markdown
Contributor

skinny85 commented Dec 16, 2021

Looks like the build failed for aws-logs?

Actually, it looks like an NPM outage:

npm ERR! 503 Service Unavailable - GET https://registry.npmjs.org/@aws-cdk%2faws-applicationautoscaling - Service Unavailable

@skinny85
Copy link
Copy Markdown
Contributor

skinny85 commented Dec 17, 2021

Let's wait a little bit, and re-try the build later.

@tobytipton
Copy link
Copy Markdown
Contributor Author

tobytipton commented Dec 17, 2021

Is there a good way to retry the build? I don't see that has an option, is that something you need to trigger?

@skinny85
Copy link
Copy Markdown
Contributor

skinny85 commented Dec 17, 2021

Merging from master ("Update branch" button) is the simplest way. You can also push an update to your branch, that will re-trigger the build.

@mergify mergify bot dismissed skinny85’s stale review December 17, 2021 19:10

Pull request has been modified.

@skinny85
Copy link
Copy Markdown
Contributor

skinny85 commented Dec 17, 2021

I've hit the button, let's see 🙂.

@tobytipton
Copy link
Copy Markdown
Contributor Author

tobytipton commented Dec 17, 2021

Ok watching, thanks.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 17, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@skinny85 skinny85 added the pr-linter/exempt-readme The PR linter will not require README changes label Dec 17, 2021
@skinny85 skinny85 changed the title fix(CodePipeline): add the ability to use different support stacks for each codepipleine feat(codepipeline): add the ability to not reuse cross-region support Stacks Dec 17, 2021
@skinny85 skinny85 changed the title feat(codepipeline): add the ability to not reuse cross-region support Stacks feat(codepipeline): add ability to not reuse cross-region support Stacks Dec 17, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 17, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Dec 17, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: e4d7c02
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit dcc9e59 into aws:master Dec 17, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 17, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@tobytipton tobytipton deleted the crossRegionSupportStack branch December 17, 2021 22:10
@skinny85 skinny85 mentioned this pull request Jan 14, 2022
Closed
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@tobytipton @TikiTDO
feat(codepipeline): add ability to not reuse cross-region support Sta…
7106c80 
…cks (aws#18043)

This provides the change proposed in feature request aws#18018 by adding the new flag.

closes aws#18018 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skinny85 skinny85 skinny85 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@skinny85 skinny85

Labels

@aws-cdk/aws-codepipeline Related to AWS CodePipeline pr-linter/exempt-readme The PR linter will not require README changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(CodePipeline): shared cross-region support Stacks cause CDK Pipelines self-mutation to fail

3 participants

@tobytipton @skinny85 @aws-cdk-automation