chore: add HTML tag to alpha package forward#18032
Conversation
When ubergen generate a barebones README for an experimental package's stable variant, add in a paragraph that directs users to the experimental library so they have an easier time finding it.
…to huijbers/forward-to-alpha
|
|
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
| '> as a separate package so that you can pin its version independently of the rest of the CDK. See the package:', | ||
| '>', | ||
| `> ${options.alphaPackageName}`, | ||
| `> <span class="package-reference">${options.alphaPackageName}</span>`, |
There was a problem hiding this comment.
| `> <span class="package-reference">${options.alphaPackageName}</span>`, | |
| `> <span class="alpha-package-reference">${options.alphaPackageName}</span>`, |
There was a problem hiding this comment.
I don't mind adding this, but I'm also not sure why it would matter whether the thing we're referring to is an alpha package or not.
Are you saying the following should not work:
<span class="alpha-package-reference">@aws-cdk/core</span>
(Leave alone whether we would emit that or not...)
There was a problem hiding this comment.
oh I see that is a good point. Nevermind.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
By tagging the `<span>` with a class, some JavaScript could detect the package reference at display time and turn it into a proper hyperlink. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
By tagging the
<span>with a class, some JavaScript could detect the package reference at display time and turn it into a proper hyperlink.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license