feat(iot): add Action to set a CloudWatch alarm#18021
feat(iot): add Action to set a CloudWatch alarm#18021mergify[bot] merged 5 commits intoaws:masterfrom
Conversation
|
|
skinny85
left a comment
There was a problem hiding this comment.
Awesome work @jerry-shao, thanks for the contribution! A few small comments, but in general looks amazing!
packages/@aws-cdk/aws-iot-actions/lib/cloudwatch-alarm-action.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-iot-actions/lib/cloudwatch-alarm-action.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-iot-actions/lib/cloudwatch-alarm-action.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/cloudwatch-alarm-action.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/cloudwatch-alarm-action.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/cloudwatch-alarm-action.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/cloudwatch-alarm-action.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/cloudwatch-alarm-action.test.ts
Outdated
Show resolved
Hide resolved
|
BTW, you might want to update with the most recent |
d6bf218 to
eabefe7
Compare
Pull request has been modified.
|
@jerry-shao is this ready for another round of reviews? |
Yup |
Ok. In the future, pleas re-request my review when you're done (there's a button in the top-right corner of the PR page, next to my avatar). |
skinny85
left a comment
There was a problem hiding this comment.
Looks fantastic @jerry-shao! A few last tiny comments, but this is in a great place already.
packages/@aws-cdk/aws-iot-actions/lib/cloudwatch-set-alarm-state-action.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/cloudwatch-set-alarm-state-action.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/cloudwatch-set-alarm-state-action.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/cloudwatch-set-alarm-state-action.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/integ.cloudwatch-set-alarm-state-action.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/integ.cloudwatch-set-alarm-state-action.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/integ.cloudwatch-set-alarm-state-action.ts
Outdated
Show resolved
Hide resolved
Pull request has been modified.
skinny85
left a comment
There was a problem hiding this comment.
Looks fantastic, thanks so much for the contribution @jerry-shao!
Thanks @skinny85 , any chance you could trigger the workflows? |
Done! |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Adding IoT Rule action for CloudWatch alarm. Fixes aws#17705 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Adding IoT Rule action for CloudWatch alarm.
Fixes #17705
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license