Skip to content

feat(aws-s3): Adding Intelligent Tiering to Bucket#18013

Merged
mergify[bot] merged 11 commits intoaws:masterfrom
makrsmark:makrsmark/s3-intelligent-tiering
Dec 15, 2021
Merged

feat(aws-s3): Adding Intelligent Tiering to Bucket#18013
mergify[bot] merged 11 commits intoaws:masterfrom
makrsmark:makrsmark/s3-intelligent-tiering

Conversation

@makrsmark
Copy link
Copy Markdown
Contributor

Allows users to add Intelligent Tiering to their s3 buckets. Modelling of CfnBucket was done before.

Fixes #16191


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link
Copy Markdown

gitpod-io bot commented Dec 14, 2021

@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label Dec 14, 2021
Copy link
Copy Markdown
Contributor

@otaviomacedo otaviomacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a minor comment on the documentation.

```ts
new s3.Bucket(this, 'MyBucket', {
intelligentTieringConfigurations: [{
name: 'foo',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could include other props here to make the usefulness of this feature more evident, like prefix, archiveAccessTierTime.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

otaviomacedo
otaviomacedo previously approved these changes Dec 15, 2021
@makrsmark
Copy link
Copy Markdown
Contributor Author

ERR! 503 Service Unavailable - GET https://registry.npmjs.org/https-proxy-agent - Service Unavailable

I think this is an issue with npm registry - other PRs are failing for the same reason but different packages

@makrsmark
Copy link
Copy Markdown
Contributor Author

@otaviomacedo could you please re-run the CodeBuild approval as npmjs should be operational again?

@mergify mergify bot dismissed otaviomacedo’s stale review December 15, 2021 18:05

Pull request has been modified.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 1816c28
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 890c4c5 into aws:master Dec 15, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 15, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@makrsmark makrsmark deleted the makrsmark/s3-intelligent-tiering branch December 15, 2021 21:19
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Allows users to add Intelligent Tiering to their s3 buckets. Modelling of CfnBucket was done before.

Fixes aws#16191

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/aws-s3 Related to Amazon S3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(s3): Configure intelligent tiering in bucket constructor

3 participants