fix(lambda): Validate Lambda "functionName" parameter#17970
fix(lambda): Validate Lambda "functionName" parameter#17970mergify[bot] merged 8 commits intoaws:masterfrom Dzhuneyt:dzhuneyt/issue-13264
Conversation
|
|
kaizencc
left a comment
There was a problem hiding this comment.
hmmm not sure why the linter didn't find these but I like my spaces :)
|
@Dzhuneyt, it's been a while since there was any action on this PR. Are you still available to work on this? |
|
Yeah. Sorry, I was on vacation. |
Pull request has been modified.
Co-authored-by: Kaizen Conroy <36202692+kaizen3031593@users.noreply.github.com>
|
@kaizen3031593 @jumic addressed your comments above. Let me know if you see anything else that can be improved. |
| this._architecture = props.architecture ?? (props.architectures && props.architectures[0]); | ||
|
|
||
| if (props.functionName && !Token.isUnresolved(props.functionName)) { | ||
| if (props.functionName.length > 140) { |
There was a problem hiding this comment.
this says that the length cannot be greater than 64 characters. Where are you gettintg the 140 from?
There was a problem hiding this comment.
I've confirmed that the number is 64 here. Going to update this PR accordingly.
| new lambda.Function(stack, `foo${invalidChar}`, { | ||
| code: new lambda.InlineCode('foo'), | ||
| handler: 'index.handler', | ||
| runtime: lambda.Runtime.NODEJS_10_X, |
There was a problem hiding this comment.
this runtime has an end-of-life set for 2/14/22. lets use Node 12 or 14.
| new lambda.Function(stack, 'foo', { | ||
| code: new lambda.InlineCode('foo'), | ||
| handler: 'index.handler', | ||
| runtime: lambda.Runtime.NODEJS_10_X, |
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes aws#13264 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes #13264
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license