feat(codecommit): allow initializing a Repository with contents by LukvonStrom · Pull Request #17968 · aws/aws-cdk

LukvonStrom · 2021-12-11T15:53:43Z

This repo introduces new properties to the constructor signature of the codecommit L2 Repository.
It allows users to upload code when creating a codecommit repository by leveraging the aws-s3-assets lib.
The user is able to upload whole directories at the moment.

The behaviour has a unit tests, and an integration test, which is passing (verified manually as well).

Closes #17967, provides a possible fix to #16958

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Co-authored-by: Ben Chaimberg <youppi3@gmail.com>

gitpod-io · 2021-12-11T15:53:46Z

…epository test

otaviomacedo · 2021-12-13T16:57:43Z

packages/@aws-cdk/aws-codecommit/test/asset-test/README.md

@@ -0,0 +1 @@
+# Test


Was this accidental?

Yep, let's kill this 🙂.

I am using it to do the integration test. See https://github.com/aws/aws-cdk/pull/17968/files#diff-026923c68996b31cf2751e6c0cebe38da74216f6f31841614b8a5604f6fe694aR82

Let's call this something like test-file.txt then. Not README.md 😃.

@skinny85 it is a README to easily verify its existence when clicking on the codecommit repo, but I can rename it :)

packages/@aws-cdk/aws-codecommit/lib/repository.ts

packages/@aws-cdk/aws-codecommit/README.md

packages/@aws-cdk/aws-codecommit/lib/repository.ts

skinny85

Thanks for the contribution @LukvonStrom! It's a great start, but I feel like we need to iterate on the API a little bit more before merging this in.

packages/@aws-cdk/aws-codecommit/lib/repository.ts

skinny85 · 2021-12-13T18:36:06Z

packages/@aws-cdk/aws-codecommit/test/asset-test/README.md

@@ -0,0 +1 @@
+# Test


Yep, let's kill this 🙂.

packages/@aws-cdk/aws-codecommit/test/integ.codecommit-code-asset.ts

packages/@aws-cdk/aws-codecommit/test/codecommit.test.ts

packages/@aws-cdk/aws-codecommit/README.md

skinny85 · 2021-12-13T18:43:46Z

packages/@aws-cdk/aws-codecommit/README.md

+      path: path.join(__dirname, 'directory/'),
+});
+
+const repo = new Repository(this, 'Repository', {


Code here should use the codecommit prefix (see examples above).

Maybe we should make it consistent with the contributing guide:
https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md#recommendations
Types from the documented module should be un-qualified

Yes, we should fix that - that's not the convention we use today (the examples should show what the customer of the library will write, so it should be qualified). Thanks for pointing that out!

And let's change it for these new examples 🙂.

packages/@aws-cdk/aws-codecommit/lib/repository.ts

packages/@aws-cdk/aws-codecommit/README.md

Pull request has been modified.

skinny85

Thanks for the contribution @LukvonStrom! A few comments before we merge this one in 🙂.

skinny85 · 2021-12-13T23:32:05Z

packages/@aws-cdk/aws-codecommit/README.md

+      path: path.join(__dirname, 'directory/'),
+});
+
+const repo = new Repository(this, 'Repository', {


Yes, we should fix that - that's not the convention we use today (the examples should show what the customer of the library will write, so it should be qualified). Thanks for pointing that out!

And let's change it for these new examples 🙂.

packages/@aws-cdk/aws-codecommit/lib/code.ts

skinny85 · 2021-12-13T23:35:59Z

packages/@aws-cdk/aws-codecommit/README.md

+```ts
+const repo = new Repository(this, 'Repository', {
+    repositoryName: 'MyRepositoryName',
+    code: Code.fromDirectory(path.join(__dirname, 'directory/'), 'develop'), // optional property, branch parameter can be omitted


I wonder if code / Code is too specific a word here. What do you think about renaming the property and the class to contents / Contents? Or maybe even contents for the property, and RepositoryContents for the class?

As Git is a version control system for primarily code, I would leave it on code for now, if that's ok with you?

packages/@aws-cdk/aws-codecommit/lib/code.ts

packages/@aws-cdk/aws-codecommit/test/codecommit.test.ts

packages/@aws-cdk/aws-codecommit/test/integ.codecommit-code-asset-zip.ts

packages/@aws-cdk/aws-codecommit/test/integ.codecommit-code-asset.ts

packages/@aws-cdk/aws-codecommit/test/integ.codecommit-code-asset-zip.ts

packages/@aws-cdk/aws-codecommit/test/integ.codecommit-code-asset.ts

skinny85

Looks great @LukvonStrom! Just a few tiny last comments, mainly around docs, before we merge this in!

packages/@aws-cdk/aws-codecommit/lib/code.ts

packages/@aws-cdk/aws-codecommit/test/codecommit.test.ts

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

Pull request has been modified.

skinny85

Looks great, thanks for the all work on this @LukvonStrom!

mergify · 2021-12-14T22:20:15Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2021-12-14T22:21:15Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
Commit ID: 8ee793f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…17968) This repo introduces new properties to the constructor signature of the codecommit L2 Repository. It allows users to upload code when creating a codecommit repository by leveraging the aws-s3-assets lib. The user is able to upload whole directories at the moment. The behaviour has a unit tests, and an integration test, which is passing (verified manually as well). Closes aws#17967, provides a possible fix to aws#16958 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

LukvonStrom and others added 12 commits August 20, 2021 11:42

fix ExecutionContext Regression

caa22b0

Apply suggestions

084e804

Co-authored-by: Ben Chaimberg <youppi3@gmail.com>

fix: render the Parameters inplace

1c98961

Fix import for test

c6c2a2e

(fix): lint and testing

551a1d8

minor formatting

920d97f

fix(test) - match missing property correctly

469f697

Merge branch 'master' into master

9e7cec2

feat(ec2): add attribute to retrieve arn of vpc

3eaa3d4

Merge branch 'master' of https://github.com/LukvonStrom/aws-cdk

bcb091b

Merge branch 'aws:master' into master

6c90cdf

feat(@aws-cdk/aws-codecommit): add code initialization for repository

d3c1bf8

github-actions bot added the @aws-cdk/aws-codecommit Related to AWS CodeCommit label Dec 11, 2021

github-actions bot assigned skinny85 Dec 11, 2021

LukvonStrom added 2 commits December 11, 2021 18:19

fix(@aws-cdk/aws-codecommit): fix and augment nonpassing codecommit r…

39148ba

…epository test

fix(codecommit): fix documentation

efb34fa

otaviomacedo reviewed Dec 13, 2021

View reviewed changes

skinny85 previously requested changes Dec 13, 2021

View reviewed changes

implement suggested Code API, add suggestions

63f0c1f

LukvonStrom requested review from otaviomacedo and skinny85 December 13, 2021 22:43

skinny85 reviewed Dec 14, 2021

View reviewed changes

implement suggested changes

00e84b7

LukvonStrom requested a review from skinny85 December 14, 2021 10:36

skinny85 previously requested changes Dec 14, 2021

View reviewed changes

Apply suggestions from code review

0717d14

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

implement better errors + error testing

8ee793f

Merge branch 'master' into master

f4ccac9

LukvonStrom requested a review from skinny85 December 14, 2021 21:38

skinny85 approved these changes Dec 14, 2021

View reviewed changes

skinny85 changed the title ~~feat(@aws-cdk/aws-codecommit): add code initialization for codecommit repository~~ feat(codecommit): allow initializing a Repository with contents Dec 14, 2021

mergify bot merged commit 54b6cc6 into aws:master Dec 14, 2021

		@@ -0,0 +1 @@
		# Test No newline at end of file

		@@ -0,0 +1 @@
		# Test No newline at end of file

Conversation

LukvonStrom commented Dec 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitpod-io bot commented Dec 11, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skinny85 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

skinny85 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skinny85 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skinny85 left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Dec 14, 2021

Uh oh!

aws-cdk-automation commented Dec 14, 2021

AWS CodeBuild CI Report

Uh oh!

Reviewers

Assignees

Labels

LukvonStrom commented Dec 11, 2021 •

edited

Loading