fix(glue): remove batchDeletePartition from grantRead() permissions#17941
Merged
mergify[bot] merged 2 commits intoaws:masterfrom Dec 10, 2021
kaizencc:gluegrant
Merged
fix(glue): remove batchDeletePartition from grantRead() permissions#17941mergify[bot] merged 2 commits intoaws:masterfrom kaizencc:gluegrant
batchDeletePartition from grantRead() permissions#17941mergify[bot] merged 2 commits intoaws:masterfrom
kaizencc:gluegrant
Conversation
|
|
batchDeletePartition from grantRead() permissions
Contributor
Author
|
renamed to the fix because I feel like that is more important to communicate to users. |
otaviomacedo
approved these changes
Dec 10, 2021
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…ns (aws#17941) It is convention in the CDK to expose the underlying `grant()` API to make it simple for users to grant custom permissions to their resource. In addition, this PR removes 'glue:BatchDeletePartition' from `readPermissions`, which was previously erroneously added. closes aws#17935 and aws#15116. BREAKING CHANGE: the grantRead API previously included 'glue:BatchDeletePartition', and now it does not. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is convention in the CDK to expose the underlying
grant()API to make it simple for users to grant custom permissions to their resource.In addition, this PR removes 'glue:BatchDeletePartition' from
readPermissions, which was previously erroneously added.closes #17935 and #15116.
BREAKING CHANGE: the grantRead API previously included 'glue:BatchDeletePartition', and now it does not.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license